Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix subquery update with generated column (#23955) #24658

Merged
merged 3 commits into from
May 14, 2021
Merged

planner: fix subquery update with generated column (#23955) #24658

merged 3 commits into from
May 14, 2021

Conversation

time-and-fate
Copy link
Member

cherry-pick #23955 to release-4.0

What problem does this PR solve?

Issue Number: close #23947

Problem Summary:

generate column will generate assign to non-updatable subquery part

What is changed and how it works?

Proposal: xxx

What's Changed, How it Works:

don't generate assign to not updatable subquery

Related changes

  • Need to cherry-pick to the release branch 5.0

Check List

Tests

  • Unit test

Side effects

  • n/a

Release note

  • Fix panic when subquery update stmt the table with generated columns

This change is Reviewable

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 14, 2021
@github-actions github-actions bot added the sig/execution SIG execution label May 14, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label May 14, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@zhouqiang-cl: /merge in this pull request requires 2 /lgtm.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lysu
Copy link
Contributor

lysu commented May 14, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 14, 2021
cfzjywxk
cfzjywxk approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • lysu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 14, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e1b5b18

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 14, 2021
@ti-chi-bot
Copy link
Member

@time-and-fate: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@time-and-fate
Copy link
Member Author

/run-unit-test

2 similar comments
@time-and-fate
Copy link
Member Author

/run-unit-test

@time-and-fate
Copy link
Member Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 4f31cb4 into pingcap:release-4.0 May 14, 2021
@zhouqiang-cl zhouqiang-cl added this to the v4.0.13 milestone May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

Assignees

@lysu lysu

Labels
cherry-pick-approved Cherry pick PR approved by release team. sig/execution SIG execution size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.13
Development

Successfully merging this pull request may close these issues.
6 participants
@time-and-fate @zhouqiang-cl @ti-chi-bot @lysu @cfzjywxk @XuHuaiyu