Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix unsigned int window function error #26010

Merged
merged 2 commits into from
Jul 8, 2021
Merged

executor: fix unsigned int window function error #26010

merged 2 commits into from
Jul 8, 2021

Conversation

newcworld
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #25956

Problem Summary: when use window slice on type of unsigned int column, the compare function will panic because it will assume that the compared value is of type int64.

What is changed and how it works?

What's Changed:
change the type of compare value

How it Works:
change the type of compare value

Check List

Tests

  • Unit test
  • Integration test

Release note

  • fix unsigned int window function error

@CLAassistant
Copy link

CLAassistant commented Jul 7, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 7, 2021
@newcworld
Copy link
Contributor Author

/run-all-tests

1 similar comment
@newcworld
Copy link
Contributor Author

/run-all-tests

mmyj
mmyj approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@mmyj mmyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 7, 2021
@mmyj
Copy link
Member

mmyj commented Jul 7, 2021

PTAL @Tjianke @wshwsh12

@ichn-hu ichn-hu mentioned this pull request Jul 7, 2021
Closed
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • mmyj
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 8, 2021
@wshwsh12
Copy link
Contributor

wshwsh12 commented Jul 8, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 63309ac

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2021
@ti-chi-bot ti-chi-bot merged commit 715891e into pingcap:master Jul 8, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 8, 2021
@newcworld @ti-srebot
cherry pick pingcap#26010 to release-5.1
5f5cbc9 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 8, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #26027

@newcworld newcworld deleted the fix_usignedint_slicewindow branch July 8, 2021 02:55
ti-chi-bot pushed a commit that referenced this pull request Jul 22, 2021
@ti-srebot
executor: fix unsigned int window function error (#26010) (#26027)
a69081f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@mmyj mmyj mmyj approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

interface conversion: interface {} is int64, not uint64
6 participants
@newcworld @CLAassistant @mmyj @ti-chi-bot @wshwsh12 @ti-srebot