Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/copr: use a ttl duration to protect a new recovered tiflash node from processing mpp tasks. #26793

Merged
merged 13 commits into from
Aug 4, 2021
Merged

store/copr: use a ttl duration to protect a new recovered tiflash node from processing mpp tasks. #26793

merged 13 commits into from
Aug 4, 2021

Conversation

hanfei1991
Copy link
Member

What problem does this PR solve?

Problem Summary:
Right now, we use a "mpp.IsAlive" rpc request to assure whether a tiflash node is available. However, in some cases, such as inactivate network service for a while, the tiflash node cannot recovered promptly. Accordingly, even though a tiflash node response with "IsAlive", it doesn't mean it can serve at once. There is a period that the node process mpp task very slowly.

Before tiflash can precisely tell whether can provide service, we throw up a work-around way to prevent from sending query to the just recovered tiflash for a period. We set up a variable "tidb_mpp_fail_store_ttl" meaning the unavailable time for the just reconvered tiflash.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

store/copr: use a ttl duration to protect a new recovered tiflash node from processing mpp tasks.

@hanfei1991
retry faster
36f32e9 
add ttl for store fail time

set var

tiny fix

cancel retry

make retry time more accurate

fix tiny bug

fix bug

change default wait time
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 2, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Aug 2, 2021
LittleFall
LittleFall reviewed Aug 3, 2021
View reviewed changes
Copy link
Contributor

@LittleFall LittleFall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see hanfei1991#16

@LittleFall
amendment for readability. (#16)
9c292d4 
* amendment for readability.

* refine name

* Update mpp.go
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 3, 2021
@hanfei1991
Update batch_coprocessor.go
daf203d 
some tiny change suggested by qizhi
LittleFall
LittleFall approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@LittleFall LittleFall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@LittleFall: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@LittleFall LittleFall removed the sig/execution SIG execution label Aug 3, 2021
LittleFall
LittleFall approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@LittleFall LittleFall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 3, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Aug 3, 2021
windtalker
windtalker approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@windtalker: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2021
@hanfei1991
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@hanfei1991: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hanfei1991 hanfei1991 removed the sig/execution SIG execution label Aug 4, 2021
windtalker
windtalker approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 4, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Aug 4, 2021
@hanfei1991
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e907210

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 4, 2021
@hanfei1991
Copy link
Member Author

/run-build

@hanfei1991
Copy link
Member Author

/run-check_dev_2

@hanfei1991
Copy link
Member Author

/run-build

@hanfei1991
Copy link
Member Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 47514c2 into pingcap:master Aug 4, 2021
@hanfei1991 hanfei1991 deleted the hanfei/detect-ttl branch August 4, 2021 08:34
@hanfei1991 hanfei1991 restored the hanfei/detect-ttl branch August 4, 2021 08:35
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 failed

@LittleFall LittleFall mentioned this pull request Aug 4, 2021
Merged
12 tasks
@hanfei1991 hanfei1991 deleted the hanfei/detect-ttl branch August 4, 2021 09:43
hanfei1991 added a commit to hanfei1991/tidb that referenced this pull request Aug 4, 2021
@hanfei1991
store/copr: use a ttl duration to protect a new recovered tiflash nod…
cf89325 
…e from processing mpp tasks. (pingcap#26793)
This was referenced Aug 4, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleFall LittleFall LittleFall approved these changes

@windtalker windtalker windtalker approved these changes

@fzhedu fzhedu Awaiting requested review from fzhedu

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/execution SIG execution size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hanfei1991 @ti-chi-bot @ti-srebot @windtalker @LittleFall