-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/copr: use a ttl duration to protect a new recovered tiflash nod… #26897
store/copr: use a ttl duration to protect a new recovered tiflash nod… #26897
Conversation
…e from processing mpp tasks. (pingcap#26793)
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 219c398
|
What problem does this PR solve?
Problem Summary: When a tiflash down is down and recovered, it possibly cannot provide service for a period. If we send query to some unstable node, it will block the whole query.
To work around, we set a fail store ttl time. During that time, we will not send query to that node.
What is changed and how it works?
Proposal: See #26793
What's Changed:
How it Works:
Check List
Tests
Side effects
Documentation
Release note