Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix wrong result for date add sub #27244

Merged
merged 12 commits into from
Aug 20, 2021
Merged

expression: fix wrong result for date add sub #27244

merged 12 commits into from
Aug 20, 2021

Conversation

lzmhhh123
Copy link
Contributor

Signed-off-by: lzmhhh123 lzmhhh123@gmail.com

What problem does this PR solve?

Issue Number: close #27232

What is changed and how it works?

How it Works:

Check List

Tests

  • Unit test
  • Integration test

Release note 

Fix the wrong result for date_add and date_sub in some cases.

@lzmhhh123
expression: fix wrong result for date add sub
bb15413 
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 16, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ichn-hu
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2021
@lzmhhh123 lzmhhh123 added needs-cherry-pick-4.0 needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 type/bugfix This PR fixes a bug. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2021
@lzmhhh123 lzmhhh123 self-assigned this Aug 16, 2021
@lzmhhh123
Copy link
Contributor Author

/cc @wshwsh12 @ichn-hu

wshwsh12
wshwsh12 reviewed Aug 16, 2021
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix CI

@ichn-hu ichn-hu mentioned this pull request Aug 16, 2021
Closed
@lzmhhh123
fix
f509c90 
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
@lzmhhh123
fix
ecc1bc2 
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 17, 2021
@lzmhhh123 lzmhhh123 removed their assignment Aug 19, 2021
ichn-hu
ichn-hu reviewed Aug 19, 2021
View reviewed changes
Copy link
Contributor

@ichn-hu ichn-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

executor/executor_test.go Outdated Show resolved Hide resolved
executor/executor_test.go Outdated Show resolved Hide resolved
wshwsh12
wshwsh12 approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 20, 2021
lzmhhh123 and others added 4 commits August 20, 2021 11:58
@lzmhhh123 @ichn-hu
Update executor/executor_test.go
a5df5fe 
Co-authored-by: 虎 <ichneumon.hu@foxmail.com>
@lzmhhh123 @ichn-hu
Update executor/executor_test.go
95f8917 
Co-authored-by: 虎 <ichneumon.hu@foxmail.com>
@lzmhhh123
Merge branch 'master' into bug-fix/fix_date_add_sub_wrong_result
b90c536
@lzmhhh123
fix
48cc58d 
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 20, 2021
@ichn-hu
Copy link
Contributor

ichn-hu commented Aug 20, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 48cc58d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 20, 2021
@ti-chi-bot ti-chi-bot merged commit c9c3463 into pingcap:master Aug 20, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 20, 2021
@lzmhhh123 @ti-srebot
cherry pick pingcap#27244 to release-4.0
1f9ffec 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 20, 2021
Closed
2 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #27451

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 20, 2021
@lzmhhh123 @ti-srebot
cherry pick pingcap#27244 to release-5.0
b58c62c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 20, 2021
Closed
2 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #27452

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 20, 2021
@lzmhhh123 @ti-srebot
cherry pick pingcap#27244 to release-5.1
2a57cdc 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 20, 2021
Closed
2 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #27453

@lzmhhh123 lzmhhh123 deleted the bug-fix/fix_date_add_sub_wrong_result branch August 20, 2021 09:32
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 20, 2021
@lzmhhh123 @ti-srebot
cherry pick pingcap#27244 to release-5.2
f8ce24b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 20, 2021
Merged
2 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #27454

ti-chi-bot pushed a commit that referenced this pull request Oct 13, 2021
@ti-srebot
expression: fix wrong result for date add sub (#27244) (#27454)
dcbb560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichn-hu ichn-hu ichn-hu approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/execution SIG execution size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

query result incorrect while date_sub result overflow the datetime filed
5 participants
@lzmhhh123 @ti-chi-bot @ichn-hu @ti-srebot @wshwsh12