Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix wrong result for date add sub (#27244) #27453

Closed
wants to merge 12 commits into from
Closed

expression: fix wrong result for date add sub (#27244) #27453

wants to merge 12 commits into from

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Aug 20, 2021 •
edited
Loading

cherry-pick #27244 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/27453

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/27453:release-5.1-c9c3463ac1b6

Signed-off-by: lzmhhh123 lzmhhh123@gmail.com

What problem does this PR solve?

Issue Number: close #27232

What is changed and how it works?

How it Works:

Check List

Tests

  • Unit test
  • Integration test

Release note 

Fix the wrong result for date_add and date_sub in some cases.

@lzmhhh123 @ti-srebot
cherry pick pingcap#27244 to release-5.1
2a57cdc 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 20, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot ti-srebot requested a review from a team as a code owner August 20, 2021 09:31
@ti-srebot ti-srebot requested review from lzmhhh123 and removed request for a team August 20, 2021 09:31
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 20, 2021
@ti-srebot ti-srebot mentioned this pull request Aug 20, 2021
Merged
2 tasks
@ti-srebot ti-srebot added component/expression sig/execution SIG execution size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.1-cherry-pick type/bugfix This PR fixes a bug. labels Aug 20, 2021
@ti-srebot ti-srebot added this to the v5.1.1 milestone Aug 20, 2021
@ti-srebot
Copy link
Contributor Author

@lzmhhh123 you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 31, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 16, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 16, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2a57cdc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 16, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@zhouqiang-cl
Copy link
Contributor

/run-check_dev

@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zhouqiang-cl
Copy link
Contributor

/run-check_dev

1 similar comment
@zhouqiang-cl
Copy link
Contributor

/run-check_dev

@lzmhhh123
Copy link
Contributor

#27452 (comment)

@lzmhhh123 lzmhhh123 closed this Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@qw4990 qw4990 qw4990 approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

@ichn-hu ichn-hu Awaiting requested review from ichn-hu

Assignees

@lzmhhh123 lzmhhh123

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/expression release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/execution SIG execution size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.1-cherry-pick
Projects
None yet
Milestone
v5.1.1
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @ti-chi-bot @zhouqiang-cl @lzmhhh123 @qw4990 @wshwsh12