Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: add test for HotRegionsHistoryTableExtractor #27899

Closed
wants to merge 1 commit into from

Conversation

IcePigZDB
Copy link
Contributor

@IcePigZDB IcePigZDB commented Sep 8, 2021

Signed-off-by: IcePigZDB icepigzdb@gmail.com

Problem Summary: Create a new table TIDB_HOT_REGIONS_HISTORY in the INFORMATION_SCHEMAT database to retrieve history hotspot information stored by PD periodically.

What problem does this PR solve?

Proposal: pingcap/tidb#27487
Associated Issue: #25281

Associated PRs in TiDB:
PRs splited from oversize PR #27224 in merge order :

  1. infoschema: add tidb_hot_regions_history virtual table #27373
  2. planner: add extractor for tidb_hot_regions_history #27374
  3. executor: add retriver for tidb_hot_regions_history  #27375
  4. planner: add test for HotRegionsHistoryTableExtractor #27899 <- current one
  5. executor: add test for hotRegionsHistoryRetriver #27900

Associated PR in PD:
PRs splited from old oversize one: tikv/pd/pull/3989

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

select * from information_schema.tidb_hot_regions_history where update_time>='2019-10-10 10:10:10' and update_time<'2019-10-11 10:10:10'

Signed-off-by: IcePigZDB <icepigzdb@gmail.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 8, 2021
@ti-srebot ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Sep 8, 2021
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 8, 2021
@IcePigZDB IcePigZDB closed this Sep 14, 2021
@IcePigZDB IcePigZDB reopened this Sep 14, 2021
@IcePigZDB
Copy link
Contributor Author

closed by #27374

@IcePigZDB IcePigZDB closed this Sep 14, 2021
@qidi1 qidi1 mentioned this pull request Sep 24, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants