-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix wrong caseWhen function for enum type #29454
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 3d3e899
|
/run-cherry-picker |
3 similar comments
/run-cherry-picker |
/run-cherry-picker |
/run-cherry-picker |
cherry pick to release-4.0 failed |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #29508 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.0 in PR #29509 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.1 in PR #29510 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.2 in PR #29511 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.3 in PR #29512 |
What problem does this PR solve?
Issue Number: close #29357
Problem Summary:
What is changed and how it works?
There are two problem in this issue:
Problem 1:
Problem 2:
BuildCastFunction is useless. See constant_fold.goL129. We should have the same behavior for all args.
Check List
Tests
Side effects
Documentation
Release note