Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix wrong caseWhen function for enum type #29454

Merged
merged 3 commits into from
Nov 5, 2021

Conversation

wshwsh12
Copy link
Contributor

@wshwsh12 wshwsh12 commented Nov 4, 2021

What problem does this PR solve?

Issue Number: close #29357

Problem Summary:

What is changed and how it works?

There are two problem in this issue:
Problem 1:

  1. caseWhenFunctionClass.getFunction get fieldType Enum from children, and construct scalarFunction caseWhenString.
  2. compareFunctionClass.getFunction get fieldType Int and Enum, and set EnumSetAsInt flag, but not re-construct caseWhen function.
  3. Get the final scalarFunction EQInt(1, CaseWhenString(0, Enum)) and pushdown. CaseWhenString can't get int value.

Problem 2:

[tidb]> SELECT 5 = (case when 0 <=> 1 then a else a end) from t;
ERROR 1105 (HY000): baseBuiltinFunc.vecEvalInt() should never be called, please contact the TiDB team for help
  1. BuildCastFunction build a cast CastStringAsString, and the fieldType is Enum.
  2. compareFunctionClass.getFunction get fieldType Int and Enum, and set EnumSetAsInt flag, but not re-construct Cast function.
  3. Get the final scalarFunction EQInt(1, CastStringAsString(Enum))). CastStringAsString can't get int value.
    BuildCastFunction is useless. See constant_fold.goL129. We should have the same behavior for all args.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix panic for caseWhen function with enum type

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 4, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ichn-hu
  • lzmhhh123

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 4, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 5, 2021
@wshwsh12
Copy link
Contributor Author

wshwsh12 commented Nov 5, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3d3e899

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 5, 2021
@wshwsh12 wshwsh12 merged commit ae65cae into pingcap:master Nov 5, 2021
@wshwsh12
Copy link
Contributor Author

wshwsh12 commented Nov 5, 2021

/run-cherry-picker

3 similar comments
@zhouqiang-cl
Copy link
Contributor

/run-cherry-picker

@zhouqiang-cl
Copy link
Contributor

/run-cherry-picker

@zhouqiang-cl
Copy link
Contributor

/run-cherry-picker

wshwsh12 added a commit to wshwsh12/tidb that referenced this pull request Nov 5, 2021
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 failed

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 5, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #29508

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 5, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #29509

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 5, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #29510

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 5, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #29511

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 5, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #29512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiKV panic with error of Cannot cast Bytes scalar value into Int
7 participants