-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix wrong caseWhen function for enum type (#29454) #29509
expression: fix wrong caseWhen function for enum type (#29454) #29509
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@wshwsh12 you're already a collaborator in bot's repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 247c674
|
cherry-pick #29454 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/29509
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #29357
Problem Summary:
What is changed and how it works?
There are two problem in this issue:
Problem 1:
Problem 2:
BuildCastFunction is useless. See constant_fold.goL129. We should have the same behavior for all args.
Check List
Tests
Side effects
Documentation
Release note