Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add missing exchange between hash-partition window and single-partition window #36025

Merged
merged 6 commits into from
Jul 8, 2022
Merged

planner: add missing exchange between hash-partition window and single-partition window #36025

merged 6 commits into from
Jul 8, 2022

Conversation

LittleFall
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #35990

Problem Summary:

miss exchange between hash-partition window and single-partition window

What is changed and how it works?

check the single-partition property when build mpp windows.

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 7, 2022
@LittleFall LittleFall requested a review from fixdb July 7, 2022 16:19
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed do-not-merge/needs-triage-completed labels Jul 7, 2022
@LittleFall
Copy link
Contributor Author

/run-all-tests

fixdb
fixdb approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ti-chi-bot
Copy link
Member

@fixdb: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

+1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Contributor

sre-bot commented Jul 8, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b234c3da3df3c0d1beffbe0b1de83c503531e1e2

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 8, 2022
windtalker
windtalker approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 8, 2022
@windtalker
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ea05e16

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2022
@LittleFall
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit fb6f6a4 into pingcap:master Jul 8, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 8, 2022
@LittleFall @ti-srebot
cherry pick pingcap#36025 to release-6.1
cd527d5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 8, 2022
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #36052

@LittleFall LittleFall deleted the bugfix/window-fix branch July 8, 2022 09:33
ti-chi-bot pushed a commit that referenced this pull request Aug 22, 2022
@ti-srebot
planner: add missing exchange between hash-partition window and singl…
e50055a 
…e-partition window (#36025) (#36052)

close #35990
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

@windtalker windtalker windtalker approved these changes

@fixdb fixdb fixdb approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Miss data shuffle between mpp window functions
7 participants
@LittleFall @ti-chi-bot @sre-bot @windtalker @ti-srebot @fixdb @AilinKid