Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add missing exchange between hash-partition window and single-partition window (#36025) #36052

Merged
merged 3 commits into from
Aug 22, 2022
Merged

planner: add missing exchange between hash-partition window and single-partition window (#36025) #36052

merged 3 commits into from
Aug 22, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jul 8, 2022 •
edited
Loading

cherry-pick #36025 to release-6.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/36052

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/36052:release-6.1-fb6f6a4fda0f

What problem does this PR solve?

Issue Number: close #35990

Problem Summary:

miss exchange between hash-partition window and single-partition window

What is changed and how it works?

check the single-partition property when build mpp windows.

Check List

Tests

  • Unit test

Release note

None

@LittleFall @ti-srebot
cherry pick pingcap#36025 to release-6.1
cd527d5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • chrysan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 8, 2022
@ti-srebot ti-srebot mentioned this pull request Jul 8, 2022
Merged
1 task
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/6.1-cherry-pick labels Jul 8, 2022
@ti-srebot
Copy link
Contributor Author

@LittleFall you're already a collaborator in bot's repo.

fixdb
fixdb approved these changes Jul 9, 2022
View reviewed changes
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ti-chi-bot
Copy link
Member

@fixdb: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

+1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 19, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 22, 2022
@chrysan
Copy link
Contributor

chrysan commented Aug 22, 2022

/merge

@ti-chi-bot
Copy link
Member

@chrysan: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 22, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 22, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/32966318494f321e11ba293a7dc8279d0bba7845

@LittleFall
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@LittleFall: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@chrysan
Copy link
Contributor

chrysan commented Aug 22, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3296631

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 22, 2022
@ti-chi-bot ti-chi-bot merged commit e50055a into pingcap:release-6.1 Aug 22, 2022
@purelind purelind added this to the v6.1.1 milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleFall LittleFall LittleFall approved these changes

@chrysan chrysan chrysan approved these changes

@fixdb fixdb fixdb approved these changes

@AilinKid AilinKid Awaiting requested review from AilinKid

@windtalker windtalker Awaiting requested review from windtalker

Assignees

@LittleFall LittleFall

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/6.1-cherry-pick
Projects
None yet
Milestone
v6.1.1
Development

Successfully merging this pull request may close these issues.
8 participants
@ti-srebot @ti-chi-bot @chrysan @sre-bot @LittleFall @fixdb @VelocityLight @purelind