Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: forbid load data with empty field terminator #36500

Merged
merged 3 commits into from
Jul 28, 2022
Merged

planner: forbid load data with empty field terminator #36500

merged 3 commits into from
Jul 28, 2022

Conversation

zyguan
Copy link
Contributor

@zyguan zyguan commented Jul 24, 2022

Signed-off-by: zyguan zhongyangguan@gmail.com

What problem does this PR solve?

Issue Number: close #33298

Problem Summary: load data with empty field terminator leads to 100% CPU usage and never finishing.

What is changed and how it works?

Just forbid load data with empty field terminator for a quick fix, since we do not support fixed-row format yet.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zyguan
planner: forbid load data with empty field terminator
3c15000 
Signed-off-by: zyguan <zhongyangguan@gmail.com>
@zyguan zyguan requested a review from cfzjywxk July 24, 2022 12:30
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • you06

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 24, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 24, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/216b818027c12f950a6683846550b21d7381dd81

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 28, 2022
@cfzjywxk cfzjywxk requested a review from you06 July 28, 2022 02:18
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 28, 2022
@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3c15000

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 28, 2022
@zyguan
Copy link
Contributor Author

zyguan commented Jul 28, 2022

Introduced by 2364fec#diff-623a44defe93b702087a0127b2fce250a09a70e1e29840d435c19c865c0e1c5aR436

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Jul 28, 2022
@ti-chi-bot ti-chi-bot merged commit bce6901 into pingcap:master Jul 28, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 28, 2022
@zyguan @ti-srebot
cherry pick pingcap#36500 to release-5.0
8242d83 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 28, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #36680

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 28, 2022
@zyguan @ti-srebot
cherry pick pingcap#36500 to release-5.1
b9a2662 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 28, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #36681

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 28, 2022
@zyguan @ti-srebot
cherry pick pingcap#36500 to release-5.2
16e4a17 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 28, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #36682

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 28, 2022
@zyguan @ti-srebot
cherry pick pingcap#36500 to release-5.3
0417611 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 28, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #36683

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 28, 2022
@zyguan @ti-srebot
cherry pick pingcap#36500 to release-5.4
9a5d5a3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 28, 2022
Open
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #36684

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 28, 2022
@zyguan @ti-srebot
cherry pick pingcap#36500 to release-6.0
f99e012 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 28, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #36685

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 28, 2022
@zyguan @ti-srebot
cherry pick pingcap#36500 to release-6.1
7a70b61 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 28, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #36686

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 28, 2022
@zyguan @ti-srebot
cherry pick pingcap#36500 to release-6.2
8dc3e73 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 28, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.2 in PR #36687

ti-chi-bot pushed a commit that referenced this pull request Aug 25, 2022
@ti-srebot
planner: forbid load data with empty field terminator (#36500) (#36686)
5263a0a 
close #33298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@you06 you06 you06 approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LOAD DATA consuming 100% CPU and never finishing
6 participants
@zyguan @ti-chi-bot @sre-bot @cfzjywxk @ti-srebot @you06