-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: forbid load data with empty field terminator (#36500) #36684
base: release-5.4
Are you sure you want to change the base?
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/run-all-tests |
@zyguan you're already a collaborator in bot's repo. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9a5d5a3197912079e6f588f936423c31fcbbc039 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-5.4 #36684 +/- ##
================================================
Coverage ? 63.8474%
================================================
Files ? 775
Lines ? 256178
Branches ? 0
================================================
Hits ? 163563
Misses ? 79659
Partials ? 12956 |
cherry-pick #36500 to release-5.4
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/36684
After apply modifications, you can push your change to this PR via:
Signed-off-by: zyguan zhongyangguan@gmail.com
What problem does this PR solve?
Issue Number: close #33298
Problem Summary: load data with empty field terminator leads to 100% CPU usage and never finishing.
What is changed and how it works?
Just forbid load data with empty field terminator for a quick fix, since we do not support fixed-row format yet.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.