Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sessiontxn/staleread: more accurate stale ts #44272

Merged
merged 5 commits into from
May 30, 2023
Merged

sessiontxn/staleread: more accurate stale ts #44272

merged 5 commits into from
May 30, 2023

Conversation

you06
Copy link
Contributor

@you06 you06 commented May 30, 2023

What problem does this PR solve?

Issue Number: close #44215

Problem Summary:

What is changed and how it works?

When calculate as-of expr, calculate now expression by cached PD ts, the stale read ts will be more accurate, and there will also be less stale read fallback.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

I also test with 100ms staleness read:

  • resolved-ts.advance-ts-interval: 100ms

nightly:

a

this PR:

b

  • resolved-ts.advance-ts-interval: 50ms

nightly:

c

this PR:

d

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Use more accurate stale read ts.

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 30, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • zyguan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 30, 2023
@you06
use cached ts to estimate now in stale read statements
e04fbb1 
Signed-off-by: you06 <you1474600@gmail.com>
@you06
fmt
a922d76 
Signed-off-by: you06 <you1474600@gmail.com>
@cfzjywxk cfzjywxk added the sig/transaction SIG:Transaction label May 30, 2023
@cfzjywxk cfzjywxk requested review from cfzjywxk and zyguan May 30, 2023 08:12
cfzjywxk
cfzjywxk approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

expression/helper.go Show resolved Hide resolved
sessiontxn/staleread/util.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 30, 2023
you06 added 3 commits May 30, 2023 16:23
@you06
bazel
57a3a33 
Signed-off-by: you06 <you1474600@gmail.com>
@you06
address comment
9e9c563 
Signed-off-by: you06 <you1474600@gmail.com>
@you06
fmt
c2b83c5 
Signed-off-by: you06 <you1474600@gmail.com>
@you06
Copy link
Contributor Author

you06 commented May 30, 2023

/retest

@you06 you06 mentioned this pull request May 30, 2023
Closed
zyguan
zyguan approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@zyguan zyguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 30, 2023
@zyguan
Copy link
Contributor

zyguan commented May 30, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 30, 2023

This pull request has been accepted and is ready to merge.

Commit hash: c2b83c5

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 30, 2023
@ti-chi-bot ti-chi-bot bot merged commit e3776f3 into pingcap:master May 30, 2023
@you06
Copy link
Contributor Author

you06 commented May 30, 2023

/cherry-pick release-6.5

@ti-chi-bot ti-chi-bot mentioned this pull request May 30, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

@you06: new pull request created to branch release-6.5: #44281.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 30, 2023
@you06 @ti-chi-bot
This is an automated cherry-pick of pingcap#44272
0814bd6 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request May 30, 2023
@ti-chi-bot
sessiontxn/staleread: more accurate stale ts (#44272) (#44281)
783cdd0 
close #44215
@you06
Copy link
Contributor Author

you06 commented Aug 2, 2023

/cherry-pick release-7.1

@ti-chi-bot
Copy link
Member

@you06: new pull request created to branch release-7.1: #45760.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 2, 2023
Merged
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 2, 2023
@you06 @ti-chi-bot
This is an automated cherry-pick of pingcap#44272
68c99a9 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@zyguan zyguan mentioned this pull request Aug 11, 2023
Open
ti-chi-bot bot pushed a commit that referenced this pull request Aug 17, 2023
@ti-chi-bot
sessiontxn/staleread: more accurate stale ts (#44272) (#45760)
79a02af 
close #44215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyguan zyguan zyguan approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/transaction SIG:Transaction size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use estimated now in stale ts calculation
4 participants
@you06 @zyguan @ti-chi-bot @cfzjywxk