-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sessiontxn/staleread: more accurate stale ts (#44272) #44281
sessiontxn/staleread: more accurate stale ts (#44272) #44281
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: you06 <you1474600@gmail.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 8fac5d3
|
/retest |
1 similar comment
/retest |
This is an automated cherry-pick of #44272
What problem does this PR solve?
Issue Number: close #44215
Problem Summary:
What is changed and how it works?
When calculate as-of expr, calculate
now
expression by cached PD ts, the stale read ts will be more accurate, and there will also be less stale read fallback.Check List
Tests
I also test with 100ms staleness read:
nightly:
this PR:
nightly:
this PR:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.