Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix 'duplicate entry' error when using br to restore AUTO_ID_CACHE=1 tables #44743

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Jun 16, 2023

What problem does this PR solve?

Issue Number: close #44716, ref #38442

Problem Summary:

#39041 use separate allocator for row id and auto id.
That is some kind of compatibility-break, although it handle the backword-compatibility carefully in the tidb side, I still miss something in the br component.

When br backup a table with auto increment column, it get the row id allocator from the meta key. It should have used the auto increment id allocator after #39041

What is changed and how it works?

The auto increment meta key of a table with AUTO_ID_CACHE=1 option is a separated one, rather than the row ID meta key.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

The steps descripted in #44716
I do think some integration test is necessory for this commit.

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 16, 2023
@tiancaiamao
Copy link
Contributor Author

/retest-required

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 16, 2023
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FAILED ddl.TestAutoIncrementForceAutoIDCache

@ti-chi-bot ti-chi-bot bot removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 16, 2023
@bb7133
Copy link
Member

bb7133 commented Jun 19, 2023

PTAL @tangenta @3pointer

@bb7133 bb7133 requested a review from tangenta June 19, 2023 02:18
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 19, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 20, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 20, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 20, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-16 16:51:06.19100132 +0000 UTC m=+363662.605605400: ☑️ agreed by xhebox.
  • 2023-06-16 16:54:35.677751204 +0000 UTC m=+363872.092355282: ✖️🔁 reset by xhebox.
  • 2023-06-20 02:02:58.694374849 +0000 UTC m=+68344.095625283: ☑️ agreed by xhebox.
  • 2023-06-20 02:07:25.470873206 +0000 UTC m=+68610.872123654: ☑️ agreed by Leavrth.

@tiancaiamao
Copy link
Contributor Author

/merge

@tiancaiamao
Copy link
Contributor Author

/retest unit-test

CI unit test fail on #44800

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 20, 2023

@tiancaiamao: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test build
  • /test canary-scan-security
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test pingcap/tidb/canary_ghpr_unit_test
  • /test pull-integration-br-test
  • /test pull-integration-mysql-test
  • /test unit-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/ghpr_build
  • pingcap/tidb/ghpr_check
  • pingcap/tidb/ghpr_check2
  • pingcap/tidb/ghpr_mysql_test
  • pingcap/tidb/ghpr_unit_test

In response to this:

/retest unit-test

CI unit test fail on #44800

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiancaiamao
Copy link
Contributor Author

/test unit-test

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #44816.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 20, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #44817.

@tiancaiamao
Copy link
Contributor Author

/run-cherry-picker

ti-chi-bot bot pushed a commit that referenced this pull request Jul 10, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate entry when using BR to restore a AUTO_ID_CACHE=1 table
5 participants