Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix 'duplicate entry' error when using br to restore AUTO_ID_CACHE=1 tables (#44743) #44817

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #44743

What problem does this PR solve?

Issue Number: close #44716, ref #38442

Problem Summary:

#39041 use separate allocator for row id and auto id.
That is some kind of compatibility-break, although it handle the backword-compatibility carefully in the tidb side, I still miss something in the br component.

When br backup a table with auto increment column, it get the row id allocator from the meta key. It should have used the auto increment id allocator after #39041

What is changed and how it works?

The auto increment meta key of a table with AUTO_ID_CACHE=1 option is a separated one, rather than the row ID meta key.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

The steps descripted in #44716
I do think some integration test is necessory for this commit.

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Jun 20, 2023
@tiancaiamao
Copy link
Contributor

/test check_dev

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 20, 2023

@tiancaiamao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

Use /test all to run all jobs.

In response to this:

/test check_dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 3, 2023
@tiancaiamao
Copy link
Contributor

/retest

@tiancaiamao tiancaiamao requested a review from xhebox July 7, 2023 05:16
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 7, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-07 05:23:27.179376545 +0000 UTC m=+50298.949715256: ☑️ agreed by xhebox.
  • 2023-07-07 05:49:30.500795403 +0000 UTC m=+51862.271134117: ☑️ agreed by Leavrth.

@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

@tiancaiamao: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

@tiancaiamao: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@purelind
Copy link
Contributor

/test all

@tiprow
Copy link

tiprow bot commented Jul 10, 2023

@purelind: No presubmit jobs available for pingcap/tidb@release-7.1

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xhebox
Copy link
Contributor

xhebox commented Jul 10, 2023

/retest

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 10, 2023
@ti-chi-bot ti-chi-bot bot merged commit c7f1ee2 into pingcap:release-7.1 Jul 10, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jul 24, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 24, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved do-not-merge/cherry-pick-not-approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants