Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disttask: fix bug when owner change #46054

Closed
wants to merge 1 commit into from

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Aug 14, 2023

What problem does this PR solve?

Issue Number: close #46014

Problem Summary:
It is possible that 2 dispatcher coexist on different server.
Then these 2 dispatcher dispatched subtasks twice.

What is changed and how it works?

Before dispatch task, check the dispatcher is the owner.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 14, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cfzjywxk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 14, 2023
@tiprow
Copy link

tiprow bot commented Aug 14, 2023

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #46054 (7703e41) into master (c34f6fc) will decrease coverage by 2.1204%.
Report is 1 commits behind head on master.
The diff coverage is 30.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46054        +/-   ##
================================================
- Coverage   74.7608%   72.6404%   -2.1204%     
================================================
  Files          1293       1300         +7     
  Lines        398103     400167      +2064     
================================================
- Hits         297625     290683      -6942     
- Misses        81108      90992      +9884     
+ Partials      19370      18492       -878     
Flag Coverage Δ
integration 25.5613% <30.0000%> (-20.7016%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0656% <ø> (ø)
br 47.6395% <ø> (-16.8901%) ⬇️

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 14, 2023

@ywqzzy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 7703e41 link true /test unit-test
idc-jenkins-ci-tidb/build 7703e41 link true /test build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@@ -211,6 +214,9 @@ func (d *dispatcher) handleRunning() error {
}

func (d *dispatcher) updateTask(taskState string, newSubTasks []*proto.Subtask, retryTimes int) (err error) {
if !d.ownerManager.IsOwner() {
Copy link
Contributor

@lance6716 lance6716 Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if the owner is dropped just after this check? There is always an interval between time of check to time of use. Can we add a version to transactional storage to detect it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

@ywqzzy ywqzzy closed this Aug 14, 2023
@ywqzzy ywqzzy mentioned this pull request Aug 14, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unstable test TestOwnerChange
2 participants