Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: upgrade grpc #48057

Merged
merged 11 commits into from
Oct 30, 2023
Merged

*: upgrade grpc #48057

merged 11 commits into from
Oct 30, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Oct 28, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #48060

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei
*: upgrade grpc
338b486 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 28, 2023
@codecov
Copy link

codecov bot commented Oct 28, 2023 •
edited
Loading

Codecov Report

Merging #48057 (6464fb6) into master (3682bd8) will increase coverage by 1.1605%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #48057        +/-   ##
================================================
+ Coverage   71.6145%   72.7751%   +1.1605%     
================================================
  Files          1401       1424        +23     
  Lines        405923     412310      +6387     
================================================
+ Hits         290700     300059      +9359     
+ Misses        95448      93350      -2098     
+ Partials      19775      18901       -874
Flag Coverage Δ
integration 42.3606% <ø> (?)
unit 71.5778% <ø> (-0.0368%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0503% <ø> (ø)
parser ∅ <ø> (∅)
br 48.6233% <ø> (-4.2975%) ⬇️

@hawkingrei
*
ab3cda0 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*
087efe4 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*
e8dc8bf 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*
f6f83e0 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*
d1583fa 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*
7c31349 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*
21613ed 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/test all

@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/test tiprow_fast_test

@pingcap pingcap deleted a comment from ti-chi-bot bot Oct 29, 2023
@hawkingrei
*
b5334a4 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei mentioned this pull request Oct 29, 2023
Merged
@hawkingrei
Copy link
Member Author

/test all

@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/test all

@hawkingrei
Copy link
Member Author

/test all

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Oct 30, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 30, 2023
@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 30, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-30 02:57:44.983475716 +0000 UTC m=+2835462.570585846: ☑️ agreed by lance6716.
  • 2023-10-30 03:54:26.169437179 +0000 UTC m=+2838863.756547324: ☑️ agreed by 3pointer.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, lance6716, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit f135464 into pingcap:master Oct 30, 2023
25 of 28 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #48078.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 30, 2023
Merged
13 tasks
@hawkingrei hawkingrei deleted the grpc_upgrade branch October 30, 2023 09:50
ti-chi-bot bot pushed a commit that referenced this pull request Oct 31, 2023
@ti-chi-bot
*: upgrade grpc (#48057) (#48078)
c0c63a5 
close #48060
@Defined2014 Defined2014 mentioned this pull request Aug 22, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@3pointer 3pointer 3pointer approved these changes

@Leavrth Leavrth Leavrth approved these changes

@disksing disksing Awaiting requested review from disksing

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gRPC-Go HTTP/2 Rapid Reset vulnerability
5 participants
@hawkingrei @ti-chi-bot @lance6716 @3pointer @Leavrth