Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: remove replace jwt-go #55595

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Aug 22, 2024

What problem does this PR solve?

Issue Number: close #37091

Problem Summary: The rely of jwt-go already removed by #48057, so we could remove the replace stmt.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 22, 2024
Copy link

tiprow bot commented Aug 22, 2024

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 22, 2024
Copy link

ti-chi-bot bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 22, 2024
Copy link

ti-chi-bot bot commented Aug 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-22 09:15:15.375456589 +0000 UTC m=+429710.509906708: ☑️ agreed by hawkingrei.
  • 2024-08-22 09:27:13.792573036 +0000 UTC m=+430428.927023152: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit 9697d3d into pingcap:master Aug 22, 2024
12 checks passed
@Defined2014 Defined2014 deleted the fix-37091 branch August 22, 2024 09:43
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.9795%. Comparing base (8f75ed3) to head (09b1f26).
Report is 32 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55595        +/-   ##
================================================
+ Coverage   72.9033%   74.9795%   +2.0761%     
================================================
  Files          1576       1581         +5     
  Lines        440819     455231     +14412     
================================================
+ Hits         321372     341330     +19958     
+ Misses        99705      93321      -6384     
- Partials      19742      20580       +838     
Flag Coverage Δ
integration 49.0218% <ø> (?)
unit 72.2341% <ø> (+0.2634%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 51.9761% <ø> (+6.0364%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

we should update jwt dependency because of github.com/form3tech-oss/jwt-go was archived
3 participants