-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: return an error when using prepared protocol with select-into statement (#49357) #49364
planner: return an error when using prepared protocol with select-into statement (#49357) #49364
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 after fixing the conflict
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fixdb, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #49364 +/- ##
================================================
Coverage ? 73.4194%
================================================
Files ? 1209
Lines ? 378841
Branches ? 0
================================================
Hits ? 278143
Misses ? 82951
Partials ? 17747 |
This is an automated cherry-pick of #49357
What problem does this PR solve?
Issue Number: close #49166
Problem Summary: planner: return an error when using prepared protocol with select-into statement
What changed and how does it work?
Limited by the current implementation, prepared protocol cannot support select-into statements, otherwise might cause some wrong results, return an error directly in this case.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.