Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: return an error when using prepared protocol with select-into statement (#49357) #49364

Merged
merged 3 commits into from
Feb 26, 2024
Merged

planner: return an error when using prepared protocol with select-into statement (#49357) #49364

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41ff7b5
This is an automated cherry-pick of #49357
qw4990 Dec 12, 2023
2406b28
fiuxp
qw4990 Feb 26, 2024
bca4915
fixup
qw4990 Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions planner/core/plan_cache_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,18 @@ func GeneratePlanCacheStmtWithAST(ctx context.Context, sctx sessionctx.Context,
return nil, nil, 0, ErrPrepareDDL
}

<<<<<<< HEAD:planner/core/plan_cache_utils.go
switch paramStmt.(type) {
case *ast.LoadDataStmt, *ast.PrepareStmt, *ast.ExecuteStmt, *ast.DeallocateStmt, *ast.NonTransactionalDMLStmt:
=======
switch stmt := paramStmt.(type) {
case *ast.ImportIntoStmt, *ast.LoadDataStmt, *ast.PrepareStmt, *ast.ExecuteStmt, *ast.DeallocateStmt, *ast.NonTransactionalDMLStmt:
>>>>>>> cf23666766d (planner: return an error when using prepared protocol with select-into statement (#49357)):pkg/planner/core/plan_cache_utils.go
return nil, nil, 0, ErrUnsupportedPs
case *ast.SelectStmt:
if stmt.SelectIntoOpt != nil {
return nil, nil, 0, ErrUnsupportedPs
}
}

// Prepare parameters should NOT over 2 bytes(MaxUint16)
Expand Down
8 changes: 8 additions & 0 deletions planner/core/plan_cacheable_checker_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,14 @@ func TestCacheable(t *testing.T) {
require.True(t, core.Cacheable(stmt, is))
}

func TestIssue49166(t *testing.T) {
store := testkit.CreateMockStore(t)
tk := testkit.NewTestKit(t, store)
tk.MustExec("use test")
tk.MustExec(`create table t (c int)`)
tk.MustContainErrMsg(`prepare stmt from "select c from t limit 1 into outfile 'text'"`, "This command is not supported in the prepared statement protocol yet")
}

func TestNonPreparedPlanCacheable(t *testing.T) {
store := testkit.CreateMockStore(t)

Expand Down