-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: memory is not allocated first if the user does not use some information from the table. #50062
Conversation
Hi @zimulala. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50062 +/- ##
=================================================
+ Coverage 36.8806% 67.0756% +30.1949%
=================================================
Files 2731 2553 -178
Lines 773730 845799 +72069
=================================================
+ Hits 285357 567325 +281968
+ Misses 463362 254616 -208746
+ Partials 25011 23858 -1153
Flags with carried forward coverage won't be shown. Click here to find out more.
|
f7cc23c
to
d1e6f2f
Compare
[LGTM Timeline notifier]Timeline:
|
/test check-dev2 |
@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, tangenta, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
…ation from the table. (pingcap#50062) close pingcap#50077
What problem does this PR solve?
Issue Number: close #50077
Problem Summary:
If a large number of tables (such as the 540k table, 2850k partitions in the scenario shown in issue) are used, the OOM situation may occur.
What changed and how does it work?
Reduce memory allocation
EncodeInt
inEncodeTableIndexPrefix
.Check List
Tests
Prior to this PR, OOM appeared every 20-30 minutes. After this PR memory is relatively stable without OOM (test 4h+).
See the memory usage chart, memory reduction of about 2G.
Before this PR:
After this PR:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.