Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: memory is not allocated first if the user does not use some information from the table. (#50062) #50166

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50062

What problem does this PR solve?

Issue Number: close #50077

Problem Summary:
If a large number of tables (such as the 540k table, 2850k partitions in the scenario shown in issue) are used, the OOM situation may occur.

What changed and how does it work?

Reduce memory allocation

  • Do not create columns(PublicColumns, VisibleColumns, WritableColumns, FullHiddenColsAndVisibleColumns) for tables that are not used by users.
  • Do preallocate for EncodeInt in EncodeTableIndexPrefix.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Prior to this PR, OOM appeared every 20-30 minutes. After this PR memory is relatively stable without OOM (test 4h+).
    See the memory usage chart, memory reduction of about 2G.

Before this PR:

eDtKc4brDk

截屏2024-01-04 16 22 02

After this PR:

7xfDRRUZda

截屏2024-01-04 16 20 46
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Jan 8, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 21, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 22, 2024
@zimulala
Copy link
Contributor

/retest-required

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 22, 2024
Copy link

ti-chi-bot bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 22, 2024
Copy link

ti-chi-bot bot commented Feb 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-22 08:57:38.855183238 +0000 UTC m=+520347.602806349: ☑️ agreed by Defined2014.
  • 2024-02-22 08:58:03.529582441 +0000 UTC m=+520372.277205551: ☑️ agreed by tangenta.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@29df3c8). Click here to learn what that means.
The diff coverage is 9.0909%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #50166   +/-   ##
================================================
  Coverage               ?   73.4452%           
================================================
  Files                  ?       1209           
  Lines                  ?     378885           
  Branches               ?          0           
================================================
  Hits                   ?     278273           
  Misses                 ?      82860           
  Partials               ?      17752           

@ti-chi-bot ti-chi-bot bot merged commit 6915d3a into pingcap:release-7.1 Feb 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants