-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: bypass order by clause for fast point get plan #50204
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50204 +/- ##
=================================================
- Coverage 70.0083% 55.3948% -14.6136%
=================================================
Files 1444 1555 +111
Lines 419997 586921 +166924
=================================================
+ Hits 294033 325124 +31091
- Misses 105634 239112 +133478
- Partials 20330 22685 +2355
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jack Yu <jackysp@gmail.com>
Signed-off-by: Jack Yu <jackysp@gmail.com>
Signed-off-by: Jack Yu <jackysp@gmail.com>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
This PR also fixed the invalid start TS. /* init */ drop table if exists account;
-- init >> 0 rows affected
/* init */ create table account (id varchar(255) primary key, val varchar(255));
-- init >> 0 rows affected
/* t1 */ begin;
-- t1 >> 0 rows affected
/* t1 */ prepare stmt1 from 'select * from account where id = ? order by id limit 1 for update';
-- t1 >> 0 rows affected
/* t1 */ set @a = "a";
-- t1 >> 0 rows affected
/* t1 */ execute stmt1 using @a;
-- t1 >> 0 rows affected
/* t1 */ commit;
-- t1 >> 0 rows affected
/* t1 */ execute stmt1 using @a;
-- t1 >> E1105: try to commit with invalid txnStartTS: 18446744073709551615 |
What problem does this PR solve?
Issue Number: close #49920
Problem Summary:
What changed and how does it work?
It's better to resolve order by clause, but it will make some duplicated code.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.