Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: bypass order by clause for fast point get plan (#50204) #50364

Merged
merged 5 commits into from
Jan 24, 2024
Merged

*: bypass order by clause for fast point get plan (#50204) #50364

merged 5 commits into from
Jan 24, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50204

What problem does this PR solve?

Issue Number: close #49920

Problem Summary:

What changed and how does it work?

It's better to resolve order by clause, but it will make some duplicated code.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@jackysp @ti-chi-bot
This is an automated cherry-pick of pingcap#50204
df683a9 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jan 12, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 12, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 12, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 23, 2024
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 23, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 23, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 23, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 23, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-23 13:42:24.897048812 +0000 UTC m=+881786.461346502: ☑️ agreed by qw4990.
  • 2024-01-23 13:53:00.541850887 +0000 UTC m=+882422.106148594: ☑️ agreed by winoros.

fixdb
fixdb approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fixdb, qw4990, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@6a5b2a3). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #50364   +/-   ##
================================================
  Coverage               ?   73.6348%           
================================================
  Files                  ?       1094           
  Lines                  ?     350527           
  Branches               ?          0           
================================================
  Hits                   ?     258110           
  Misses                 ?      75834           
  Partials               ?      16583

@ti-chi-bot ti-chi-bot bot merged commit 95464e7 into pingcap:release-6.5 Jan 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@qw4990 qw4990 qw4990 approved these changes

@fixdb fixdb fixdb approved these changes

Assignees

@jackysp jackysp

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @fixdb @qw4990 @winoros @jackysp