-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: create database by db pool #50771
Conversation
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Hi @Leavrth. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50771 +/- ##
================================================
+ Coverage 70.3318% 76.0027% +5.6708%
================================================
Files 1456 1465 +9
Lines 420913 439267 +18354
================================================
+ Hits 296036 333855 +37819
+ Misses 104509 85194 -19315
+ Partials 20368 20218 -150
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: 3pointer <qdlc2010@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #50767
Problem Summary:
br restore is very slowly if there are many databases(2000+)
What changed and how does it work?
create database by db pool
Check List
Tests
40 minutes -> 5 minutes
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.