Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: create database by db pool (#50771) #51026

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50771

What problem does this PR solve?

Issue Number: close #50767

Problem Summary:
br restore is very slowly if there are many databases(2000+)

What changed and how does it work?

create database by db pool

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

40 minutes -> 5 minutes

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Leavrth and others added 2 commits February 7, 2024 03:48
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Co-authored-by: 3pointer <qdlc2010@gmail.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Feb 7, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 7, 2024
13 tasks
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 22, 2024
@Leavrth
Copy link
Contributor

Leavrth commented Mar 27, 2024

/retest

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 27, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 27, 2024
Copy link

ti-chi-bot bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 27, 2024
Copy link

ti-chi-bot bot commented Mar 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-27 10:25:18.925684068 +0000 UTC m=+2063545.947930457: ☑️ agreed by YuJuncen.
  • 2024-03-27 10:27:55.937445645 +0000 UTC m=+2063702.959692033: ☑️ agreed by Leavrth.

@Leavrth
Copy link
Contributor

Leavrth commented Mar 27, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@2ec7e32). Click here to learn what that means.
The diff coverage is 56.5217%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #51026   +/-   ##
================================================
  Coverage               ?   73.6546%           
================================================
  Files                  ?       1095           
  Lines                  ?     350946           
  Branches               ?          0           
================================================
  Hits                   ?     258488           
  Misses                 ?      75855           
  Partials               ?      16603           

@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Mar 27, 2024
Copy link

ti-chi-bot bot commented Mar 27, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Leavrth Leavrth closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved do-not-merge/cherry-pick-not-approved do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants