Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: support use like to build range for new collation columns #51164

Merged
merged 11 commits into from
Feb 20, 2024
Merged

*: support use like to build range for new collation columns #51164

merged 11 commits into from
Feb 20, 2024

Conversation

time-and-fate
Copy link
Member

What problem does this PR solve?

Issue Number: close #48181

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Feb 19, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 19, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Feb 19, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 19, 2024 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@def88be). Click here to learn what that means.
The diff coverage is 82.6087%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-7.5     #51164   +/-   ##
================================================
  Coverage               ?   72.4840%           
================================================
  Files                  ?       1404           
  Lines                  ?     411024           
  Branches               ?          0           
================================================
  Hits                   ?     297927           
  Misses                 ?      93477           
  Partials               ?      19620
Flag Coverage Δ
unit 72.4840% <82.6087%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.3430% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 19, 2024
@time-and-fate time-and-fate changed the title *: support use like to build range for new collation columns *: support use like to build range for new collation columns | tidb-test=pr/2299 Feb 19, 2024
@time-and-fate
Copy link
Member Author

/retest

fixdb
fixdb approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 20, 2024
@time-and-fate time-and-fate mentioned this pull request Feb 20, 2024
Closed
13 tasks
@fixdb fixdb requested a review from AilinKid February 20, 2024 05:17
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fixdb, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 20, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-20 04:03:09.893015153 +0000 UTC m=+329878.640638265: ☑️ agreed by fixdb.
  • 2024-02-20 05:20:55.075326535 +0000 UTC m=+334543.822949643: ☑️ agreed by hi-rustin.

@time-and-fate
Copy link
Member Author

/hold
waiting for tidb-test side

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2024
@time-and-fate
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2024
@wuhuizuo
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2024
@wuhuizuo
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2024
@wuhuizuo wuhuizuo added priority/P0 The issue has P0 priority. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 20, 2024
@wuhuizuo
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2024
@time-and-fate time-and-fate changed the title *: support use like to build range for new collation columns | tidb-test=pr/2299 *: support use like to build range for new collation columns Feb 20, 2024
@time-and-fate
Copy link
Member Author

/retest

This was referenced Feb 20, 2024
Merged
Merged
Merged
Merged
Merged
@time-and-fate
Copy link
Member Author

/test check-dev2

@pingcap pingcap deleted a comment from tiprow bot Feb 20, 2024
@wuhuizuo wuhuizuo mentioned this pull request Feb 20, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot merged commit 1dae341 into pingcap:release-7.5 Feb 20, 2024
16 of 18 checks passed
@bb7133 bb7133 mentioned this pull request Feb 27, 2024
Closed
@time-and-fate time-and-fate mentioned this pull request Apr 19, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@fixdb fixdb fixdb approved these changes

@AilinKid AilinKid Awaiting requested review from AilinKid

Assignees
No one assigned
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm priority/P0 The issue has P0 priority. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@time-and-fate @wuhuizuo @fixdb @Rustin170506 @ti-chi-bot