-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: replace context in planbuilder to PlanContext #51172
Conversation
Hi @lcwangchao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a64f587
to
f009876
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51172 +/- ##
=================================================
- Coverage 70.6508% 54.9051% -15.7458%
=================================================
Files 1467 1576 +109
Lines 434783 604488 +169705
=================================================
+ Hits 307178 331895 +24717
- Misses 108424 249665 +141241
- Partials 19181 22928 +3747
Flags with carried forward coverage won't be shown. Click here to find out more.
|
f009876
to
e19a967
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #51171, ref #51070
What changed and how does it work?
In #51074 , we have introduced
PlanContext
to provider context for planners. In this PR, we usePlanContext
in more places like planbuilder.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.