Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: Update client-go to support receiving feedback information and adapt interface changes #51413

Merged
merged 8 commits into from
Feb 29, 2024

Conversation

MyonKeminta
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #51412

Problem Summary:

What changed and how does it work?

This PR updates client-go and follow the interface changes that were made in client-go repo.

The latest client-go supports receiving health feedback information from client-go, but has not yet made use of them. It's needed to update the dependency in TiDB repo immediately as the incompatibility of the interface may break some CI.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 29, 2024
Copy link

tiprow bot commented Feb 29, 2024

Hi @MyonKeminta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 29, 2024
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Merging #51413 (b78577b) into master (a20068f) will increase coverage by 2.2842%.
Report is 23 commits behind head on master.
The diff coverage is 60.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51413        +/-   ##
================================================
+ Coverage   70.6315%   72.9157%   +2.2842%     
================================================
  Files          1461       1462         +1     
  Lines        434861     439736      +4875     
================================================
+ Hits         307149     320637     +13488     
+ Misses       108405      99096      -9309     
- Partials      19307      20003       +696     
Flag Coverage Δ
integration 49.1316% <60.0000%> (?)
unit 70.3748% <60.0000%> (-0.0501%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.0940% <ø> (+5.2471%) ⬆️

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta
Copy link
Contributor Author

/test mysql-test

Copy link

tiprow bot commented Feb 29, 2024

@MyonKeminta: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 29, 2024
Copy link

ti-chi-bot bot commented Feb 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-29 05:45:50.128563655 +0000 UTC m=+1113638.876186767: ☑️ agreed by SeaRise.
  • 2024-02-29 07:06:06.249623648 +0000 UTC m=+1118454.997246758: ☑️ agreed by ekexium.

Copy link

ti-chi-bot bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, ekexium, SeaRise, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [crazycs520,ekexium,zyguan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 44b1598 into pingcap:master Feb 29, 2024
23 checks passed
@MyonKeminta MyonKeminta deleted the m/receive-health-feedback branch February 29, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants