-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store: Update client-go to support receiving feedback information and adapt interface changes #51413
store: Update client-go to support receiving feedback information and adapt interface changes #51413
Conversation
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
…ve-health-feedback
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Hi @MyonKeminta. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51413 +/- ##
================================================
+ Coverage 70.6315% 72.9157% +2.2842%
================================================
Files 1461 1462 +1
Lines 434861 439736 +4875
================================================
+ Hits 307149 320637 +13488
+ Misses 108405 99096 -9309
- Partials 19307 20003 +696
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test mysql-test |
@MyonKeminta: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crazycs520, ekexium, SeaRise, zyguan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #51412
Problem Summary:
What changed and how does it work?
This PR updates client-go and follow the interface changes that were made in client-go repo.
The latest client-go supports receiving health feedback information from client-go, but has not yet made use of them. It's needed to update the dependency in TiDB repo immediately as the incompatibility of the interface may break some CI.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.