Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: load region info from pd in batch #51333

Merged
merged 20 commits into from
Mar 1, 2024

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Feb 27, 2024

What problem does this PR solve?

Issue Number: close #51326

Problem Summary:

What changed and how does it work?

related to tikv/client-go#1189
waiting for #51413 to update client-go

For the table with 150K region
select * from table limit 1
before: 13.61 sec
this pr: 0.80 sec

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 27, 2024
Copy link

tiprow bot commented Feb 27, 2024

Hi @SeaRise. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Merging #51333 (3aa36f4) into master (44b1598) will increase coverage by 2.5225%.
Report is 11 commits behind head on master.
The diff coverage is 91.2500%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51333        +/-   ##
================================================
+ Coverage   70.6356%   73.1582%   +2.5225%     
================================================
  Files          1462       1462                
  Lines        435011     439207      +4196     
================================================
+ Hits         307273     321316     +14043     
+ Misses       108424      97961     -10463     
- Partials      19314      19930       +616     
Flag Coverage Δ
integration 49.7097% <73.7500%> (?)
unit 70.8047% <91.2500%> (+0.3852%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4518% <ø> (+5.6099%) ⬆️

@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 27, 2024

/retest

Copy link

tiprow bot commented Feb 27, 2024

@SeaRise: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 27, 2024

/retest

Copy link

tiprow bot commented Feb 27, 2024

@SeaRise: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 27, 2024

/retest

Copy link

tiprow bot commented Feb 27, 2024

@SeaRise: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 28, 2024

/retest

Copy link

tiprow bot commented Feb 28, 2024

@SeaRise: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 28, 2024
@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 28, 2024

/retest

Copy link

tiprow bot commented Feb 28, 2024

@SeaRise: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/store/copr/key_ranges.go Outdated Show resolved Hide resolved
@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 29, 2024

/retest

Copy link

tiprow bot commented Feb 29, 2024

@SeaRise: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 29, 2024
Copy link

ti-chi-bot bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [guo-shaoge,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 1, 2024
Copy link

ti-chi-bot bot commented Mar 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-29 09:35:04.075179517 +0000 UTC m=+1127392.822802628: ☑️ agreed by windtalker.
  • 2024-03-01 01:51:02.401891691 +0000 UTC m=+1185951.149514797: ☑️ agreed by guo-shaoge.

Copy link

tiprow bot commented Mar 1, 2024

@SeaRise: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 3aa36f4 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 1, 2024

/retest

Copy link

tiprow bot commented Mar 1, 2024

@SeaRise: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 1, 2024

/retest

Copy link

tiprow bot commented Mar 1, 2024

@SeaRise: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 1d24b1c into pingcap:master Mar 1, 2024
22 of 23 checks passed
@SeaRise SeaRise deleted the load_region_info_in_cache branch March 1, 2024 02:46
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Mar 5, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #51491.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #51492.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load region info from pd in batch
4 participants