Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: load region info from pd in batch(#51333) #51469

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Mar 4, 2024

This is a cherry-pick of #51333

What problem does this PR solve?

Issue Number: close #51326

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 4, 2024
Copy link

tiprow bot commented Mar 4, 2024

Hi @SeaRise. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 4, 2024

/retest

Copy link

tiprow bot commented Mar 4, 2024

@SeaRise: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@5461751). Click here to learn what that means.
The diff coverage is 86.6071%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #51469   +/-   ##
================================================
  Coverage               ?   73.4274%           
================================================
  Files                  ?       1212           
  Lines                  ?     379557           
  Branches               ?          0           
================================================
  Hits                   ?     278699           
  Misses                 ?      83060           
  Partials               ?      17798           

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 4, 2024

/label type/check-pick-for-release-7.1

Copy link

ti-chi-bot bot commented Mar 4, 2024

@SeaRise: The label(s) type/check-pick-for-release-7.1 cannot be applied. These labels are supported: fuzz/sqlancer, challenge-program, compatibility-breaker, first-time-contributor, contribution, good first issue, correctness, duplicate, proposal, security, ok-to-test, needs-ok-to-test, needs-more-info, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.5, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.5, needs-cherry-pick-release-7.6, affects-5.4, affects-6.1, affects-6.5, affects-7.1, affects-7.5, affects-7.6, may-affects-5.4, may-affects-6.1, may-affects-6.5, may-affects-7.1, may-affects-7.5, may-affects-7.6.

In response to this:

/label type/check-pick-for-release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 4, 2024

/type check-pick-for-release-7.1

Copy link

ti-chi-bot bot commented Mar 4, 2024

@SeaRise: The label(s) type/check-pick-for-release-7.1 cannot be applied, because the repository doesn't have them.

In response to this:

/type check-pick-for-release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 4, 2024

/type cherry-pick-for-release-7.1

@ti-chi-bot ti-chi-bot bot added the type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. label Mar 4, 2024
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 4, 2024

/cc @windtalker @guo-shaoge

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 5, 2024
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 5, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2024
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 7, 2024

/hold cancel

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2024
Copy link

ti-chi-bot bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [guo-shaoge,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 7, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 7, 2024
Copy link

ti-chi-bot bot commented Mar 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-05 02:18:14.727374446 +0000 UTC m=+133521.749620831: ☑️ agreed by windtalker.
  • 2024-03-07 03:36:42.933993961 +0000 UTC m=+311029.956240350: ☑️ agreed by guo-shaoge.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 11, 2024
@ti-chi-bot ti-chi-bot bot merged commit b3ab907 into pingcap:release-7.1 Mar 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants