Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: fix the possible wrong result for stats_healthy #52319

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

winoros
Copy link
Member

@winoros winoros commented Apr 2, 2024

What problem does this PR solve?

Issue Number: ref #29769

Problem Summary:

What changed and how does it work?

If the table's last analyze version is 0. It has not been analyzed yet.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@winoros winoros added the sig/planner SIG: Planner label Apr 2, 2024
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Merging #52319 (603b11b) into master (8f5f608) will increase coverage by 2.2214%.
Report is 2 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52319        +/-   ##
================================================
+ Coverage   72.1348%   74.3563%   +2.2214%     
================================================
  Files          1467       1467                
  Lines        426648     427376       +728     
================================================
+ Hits         307762     317781     +10019     
+ Misses        99699      89818      -9881     
- Partials      19187      19777       +590     
Flag Coverage Δ
integration 48.8331% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 49.4041% <ø> (+8.8197%) ⬆️

Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks! 👍

Copy link

ti-chi-bot bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,hi-rustin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 2, 2024
Copy link

ti-chi-bot bot commented Apr 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-02 11:02:21.362497371 +0000 UTC m=+355402.890037913: ☑️ agreed by hawkingrei.
  • 2024-04-02 11:26:27.113757831 +0000 UTC m=+356848.641298370: ☑️ agreed by hi-rustin.

@ti-chi-bot ti-chi-bot bot merged commit 4a92d81 into pingcap:master Apr 2, 2024
23 checks passed
@winoros winoros deleted the fix-stats-healthy branch April 2, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants