Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: fix wrong stats healthy check #52352

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

winoros
Copy link
Member

@winoros winoros commented Apr 4, 2024

What problem does this PR solve?

Issue Number: ref #52319

Problem Summary:

What changed and how does it work?

The IsAnalyzed is added to the wrong place.

image

The 100% is correct, but [0, 50) is wrong.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 4, 2024
@winoros winoros added the skip-issue-check Indicates that a PR no need to check linked issue. label Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Merging #52352 (0df6fe8) into master (555ce02) will increase coverage by 3.3218%.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52352        +/-   ##
================================================
+ Coverage   70.1481%   73.4700%   +3.3218%     
================================================
  Files          1485       1467        -18     
  Lines        419217     426781      +7564     
================================================
+ Hits         294073     313556     +19483     
+ Misses       105716      93424     -12292     
- Partials      19428      19801       +373     
Flag Coverage Δ
integration 23.9022% <100.0000%> (?)
unit 70.9663% <25.0000%> (+1.9736%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 49.2987% <ø> (+7.0507%) ⬆️

@winoros
Copy link
Member Author

winoros commented Apr 5, 2024

image
The correct one

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 6, 2024
Copy link

ti-chi-bot bot commented Apr 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,hi-rustin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 7, 2024
Copy link

ti-chi-bot bot commented Apr 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-06 13:46:24.007375406 +0000 UTC m=+710845.534915949: ☑️ agreed by hawkingrei.
  • 2024-04-07 05:19:44.514145903 +0000 UTC m=+766846.041686449: ☑️ agreed by hi-rustin.

@ti-chi-bot ti-chi-bot bot merged commit 03f8dd1 into pingcap:master Apr 7, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants