ddl: Reorganize Partition failure/rollback tests and fixes #53544
Conversation
Co-authored-by: D3Hunter <jujj603@gmail.com>
| NewPartitionIDs []int64 `json:"new_partition_ids,omitempty"` | ||
| // OriginalPartitionIDsOrder is only needed for rollback of Reorganize Partition for | ||
| // LIST partitions, since in StateDeleteReorganize we don't know the old order any longer. | ||
| OriginalPartitionIDsOrder []int64 `json:"original_partition_ids_order,omitempty"` |
There was a problem hiding this comment.
can this field saved in job args, see https://github.com/pingcap/tidb/pull/56163/files#diff-0a328bfc50df4984d8b701f6cfb588c8bc675992e32e00ae05f2d900147ea8dfR357-R373
There was a problem hiding this comment.
Yes, I was not aware of this work, but that is a very good improvement and suggestion!
OriginalPartitionIDsOrder is only used for rollback and can be in the job struct instead!
@D3Hunter How do we make it happen, should I change it in this PR, wait for #56163 or create a follow up PR when both are merged?
There was a problem hiding this comment.
#56163 merged. both ways lgtm
There was a problem hiding this comment.
I will make a follow up PR to move the OriginalPartitionIDsOrder to the job.Args v2 struct, with the new type handling.
|
/approve for ddl/meta pkg |
|
/retest |
|
@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, D3Hunter, Defined2014 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
mjonss
removed
the
needs-rebase
|
/retest |
|
@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: ref #45133
Problem Summary:
Added tests, with failpoints for onReorganizePartition and fixes for found issues.
Follow up of #53277
Will see how to backport tests and fixes
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.