Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic after inject an error in onReorganizePartition in StateDeleteReorganization state #56634

Closed
fzzf678 opened this issue Oct 14, 2024 · 2 comments · Fixed by #56786
Closed

Panic after inject an error in onReorganizePartition in StateDeleteReorganization state #56634

fzzf678 opened this issue Oct 14, 2024 · 2 comments · Fixed by #56786
Assignees
@mjonss
Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. component/tablepartition This issue is related to Table Partition of TiDB. impact/panic severity/major type/bug The issue is confirmed as a bug. type/regression

Comments

@fzzf678
Copy link
Contributor

fzzf678 commented Oct 14, 2024

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Ref: https://github.com/pingcap/tidb/compare/master...fzzf678:tidb:test_partition?expand=1

  1. inject a error an StateDeleteReorganization state, mock error for updateVersionAndTableInfo
  2. run sql like: alter table t partition by range(a) (partition p1 values less than (20))

2. What did you expect to see? (Required)

no panic

3. What did you see instead (Required)

panic

[2024/10/14 16:03:13.188 +08:00] [ERROR] [misc.go:115] ["panic in the recoverable goroutine"] [label=domain] [funcInfo=loadSchemaInLoop] [r="runtime error: index out of range [0] with length 0"] [stack="github.com/pingcap/tidb/pkg/util.Recover\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/util/misc.go:119\nruntime.gopanic\n\t/Users/fanzhou/.gvm/pkgsets/go1.22.4/global/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.0.darwin-arm64/src/runtime/panic.go:785\nruntime.goPanicIndex\n\t/Users/fanzhou/.gvm/pkgsets/go1.22.4/global/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.0.darwin-arm64/src/runtime/panic.go:115\ngh.neting.cc/pingcap/tidb/pkg/table/tables.getRangeLocateExprs\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/table/tables/partition.go:754\ngh.neting.cc/pingcap/tidb/pkg/table/tables.generateRangePartitionExpr\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/table/tables/partition.go:719\ngh.neting.cc/pingcap/tidb/pkg/table/tables.newPartitionExpr\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/table/tables/partition.go:280\ngh.neting.cc/pingcap/tidb/pkg/table/tables.newPartitionedTable\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/table/tables/partition.go:158\ngh.neting.cc/pingcap/tidb/pkg/table/tables.TableFromMeta\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/table/tables/tables.go:226\ngh.neting.cc/pingcap/tidb/pkg/infoschema.tableFromMeta\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/infoschema/builder.go:916\ngh.neting.cc/pingcap/tidb/pkg/infoschema.(*Builder).createSchemaTablesForDB\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/infoschema/builder.go:945\ngh.neting.cc/pingcap/tidb/pkg/infoschema.(*Builder).InitWithDBInfos\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/infoschema/builder.go:896\ngh.neting.cc/pingcap/tidb/pkg/domain.(*Domain).loadInfoSchema\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/domain/domain.go:386\ngh.neting.cc/pingcap/tidb/pkg/domain.(*Domain).Reload\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/domain/domain.go:766\ngh.neting.cc/pingcap/tidb/pkg/domain.(*Domain).loadSchemaInLoop\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/domain/domain.go:1104\ngh.neting.cc/pingcap/tidb/pkg/domain.(*Domain).Start.func2\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/domain/domain.go:1495\ngh.neting.cc/pingcap/tidb/pkg/util.(*WaitGroupEnhancedWrapper).Run.func1\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/util/wait_group_wrapper.go:99"] [stack="github.com/pingcap/tidb/pkg/util.Recover\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/util/misc.go:115\nruntime.gopanic\n\t/Users/fanzhou/.gvm/pkgsets/go1.22.4/global/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.0.darwin-arm64/src/runtime/panic.go:785\nruntime.goPanicIndex\n\t/Users/fanzhou/.gvm/pkgsets/go1.22.4/global/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.0.darwin-arm64/src/runtime/panic.go:115\ngh.neting.cc/pingcap/tidb/pkg/table/tables.getRangeLocateExprs\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/table/tables/partition.go:754\ngh.neting.cc/pingcap/tidb/pkg/table/tables.generateRangePartitionExpr\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/table/tables/partition.go:719\ngh.neting.cc/pingcap/tidb/pkg/table/tables.newPartitionExpr\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/table/tables/partition.go:280\ngh.neting.cc/pingcap/tidb/pkg/table/tables.newPartitionedTable\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/table/tables/partition.go:158\ngh.neting.cc/pingcap/tidb/pkg/table/tables.TableFromMeta\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/table/tables/tables.go:226\ngh.neting.cc/pingcap/tidb/pkg/infoschema.tableFromMeta\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/infoschema/builder.go:916\ngh.neting.cc/pingcap/tidb/pkg/infoschema.(*Builder).createSchemaTablesForDB\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/infoschema/builder.go:945\ngh.neting.cc/pingcap/tidb/pkg/infoschema.(*Builder).InitWithDBInfos\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/infoschema/builder.go:896\ngh.neting.cc/pingcap/tidb/pkg/domain.(*Domain).loadInfoSchema\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/domain/domain.go:386\ngh.neting.cc/pingcap/tidb/pkg/domain.(*Domain).Reload\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/domain/domain.go:766\ngh.neting.cc/pingcap/tidb/pkg/domain.(*Domain).loadSchemaInLoop\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/domain/domain.go:1104\ngh.neting.cc/pingcap/tidb/pkg/domain.(*Domain).Start.func2\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/domain/domain.go:1495\ngh.neting.cc/pingcap/tidb/pkg/util.(*WaitGroupEnhancedWrapper).Run.func1\n\t/Users/fanzhou/Documents/GitHub/tidb/pkg/util/wait_group_wrapper.go:99"]

4. What is your TiDB version? (Required)

master
@fzzf678 fzzf678 added type/bug The issue is confirmed as a bug. component/ddl This issue is related to DDL of TiDB. labels Oct 14, 2024
@fzzf678
Copy link
Contributor Author

fzzf678 commented Oct 14, 2024

@mjonss please take a look

@fzzf678 fzzf678 mentioned this issue Oct 14, 2024
Merged
13 tasks
@mjonss mjonss self-assigned this Oct 14, 2024
@mjonss mjonss mentioned this issue Oct 22, 2024
Merged
13 tasks
@mjonss
Copy link
Contributor

mjonss commented Oct 22, 2024

regression from #53544

@mjonss mjonss added type/regression component/tablepartition This issue is related to Table Partition of TiDB. labels Oct 22, 2024
@ti-chi-bot ti-chi-bot bot added the affects-8.5 This bug affects the 8.5.x(LTS) versions. label Nov 1, 2024
ti-chi-bot bot pushed a commit that referenced this issue Nov 15, 2024
@mjonss
ddl: Corrected index management during REORGANIZE PARTITION (#56786)
938ed70 
close #56634
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this issue Nov 15, 2024
@mjonss @ti-chi-bot
ddl: Corrected index management during REORGANIZE PARTITION (pingcap#…
d9c801f 
…56786)

close pingcap#56634
@ti-chi-bot ti-chi-bot mentioned this issue Nov 15, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Nov 16, 2024
@ti-chi-bot
ddl: Corrected index management during REORGANIZE PARTITION (#56786) (#…
6bcd156 
…57426)

close #56634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjonss mjonss

Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. component/tablepartition This issue is related to Table Partition of TiDB. impact/panic severity/major type/bug The issue is confirmed as a bug. type/regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ddl: Corrected index management during REORGANIZE PARTITION mjonss/tidb
3 participants
@jebter @mjonss @fzzf678