ddl: clean ingest temp data dir in background loop #54008
Conversation
ti-chi-bot
bot
added
release-note-none
|
Hi @tangenta. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54008 +/- ##
=================================================
- Coverage 72.5095% 56.1910% -16.3185%
=================================================
Files 1508 1637 +129
Lines 431943 610508 +178565
=================================================
+ Hits 313200 343051 +29851
- Misses 99351 244133 +144782
- Partials 19392 23324 +3932
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pkg/ddl/ingest/env.go
Outdated
| // GenLightningDataDirForTest is only used for test. | ||
| var GenLightningDataDirForTest = genLightningDataDir | ||
| // CleanUpTempDir reads the temp dir and removes the stale index data. | ||
| // This function will get |
There was a problem hiding this comment.
comment is not completed
pkg/ddl/ingest/env.go
Outdated
| // CleanUpTempDir reads the temp dir and removes the stale index data. | ||
| // This function will get | ||
| func CleanUpTempDir(ctx context.Context, se sessionctx.Context, path string) { | ||
| err := os.MkdirAll(path, 0700) |
There was a problem hiding this comment.
clean up don't need to create the folder 🤔
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #54007
Problem Summary:
What changed and how does it work?
Clean ingest temp data dir in background loop
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.