executor: record index usage for the clustered primary keys #55602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-tests-checked
release-note
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #55602 +/- ##
=================================================
- Coverage 72.8509% 56.0005% -16.8504%
=================================================
Files 1598 1723 +125
Lines 444454 619956 +175502
=================================================
+ Hits 323789 347179 +23390
- Misses 100741 249204 +148463
- Partials 19924 23573 +3649
Flags with carried forward coverage won't be shown. Click here to find out more.
|
YangKeao
force-pushed
the
primary-key-index-usage
branch
2 times, most recently
from
ffc0814
to
3fec58d
Compare
ti-chi-bot
bot
added
size/L
YangKeao
force-pushed
the
primary-key-index-usage
branch
from
3fec58d
to
cc43ace
Compare
qw4990
approved these changes
Aug 30, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
YangKeao
force-pushed
the
primary-key-index-usage
branch
from
cc43ace
to
100dc3f
Compare
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
YangKeao
force-pushed
the
primary-key-index-usage
branch
from
100dc3f
to
711600e
Compare
breezewish
added a commit
to breezewish/tidb
that referenced
this pull request
Sep 8, 2024
* origin/master: (33 commits) build(deps): bump github.com/prometheus/common from 0.55.0 to 0.57.0 (pingcap#55762) build(deps): bump golang.org/x/sys from 0.24.0 to 0.25.0 (pingcap#55894) planner: fix incorrect estRows with global index and json column (pingcap#55842) ddl, stat: switch to new struct for add/truncate/drop partition (pingcap#55893) planner: hide instance plan cache eviction log if no plan is evicted (pingcap#55918) expression: support tidb encode key function (pingcap#51678) planner: fix incorrect maintenance of `handleColHelper` for recursive CTE (pingcap#55732) executor: some code refine of hash join v2 (pingcap#55887) infoschema, meta: fix wrong auto id after `rename table` (pingcap#55847) ddl/ingest: set `minCommitTS` when detect remote duplicate keys (pingcap#55588) planner: move index advisor into the kernel (pingcap#55874) ddl, stats: switch to new struct for create/truncate table (pingcap#55811) executor: avoid new small objects in probe stage of hash join v2 (pingcap#55855) *: Add tidbCPU/tikvCPU into system tables (pingcap#55455) ddl: use static contexts in `NewReorgCopContext` (pingcap#55823) executor: fix index out of range bug in hash join v2 (pingcap#55864) executor: record index usage for the clustered primary keys (pingcap#55602) domain: load all non-public tables into infoschema (pingcap#55142) test: fix unstable TestShowViewPriv (pingcap#55868) ttl: add `varbinary` case for `TestSplitTTLScanRangesWithBytes` (pingcap#55863) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #55601
Problem Summary:
Record the index usage for primary keys.
What changed and how does it work?
Also record the scanned rows for clustered primary key in the following executors:
TableReaderExecutor.IndexMergeExecutor.Check List
Tests
Side effects
Documentation
Release note