executor: some code refine of hash join v2 #55887
Conversation
ti-chi-bot
bot
added
release-note-none
|
Hi @windtalker. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55887 +/- ##
=================================================
- Coverage 72.8824% 56.0114% -16.8711%
=================================================
Files 1601 1728 +127
Lines 445331 620786 +175455
=================================================
+ Hits 324568 347711 +23143
- Misses 100789 249405 +148616
- Partials 19974 23670 +3696
Flags with carried forward coverage won't be shown. Click here to find out more.
|
windtalker
force-pushed
the
hash_join_v2_code_refine
branch
from
fd614ee
to
6c8e256
Compare
|
/run check_dev |
windtalker
force-pushed
the
hash_join_v2_code_refine
branch
from
249bd14
to
cdf6c88
Compare
|
/test check-dev2 |
|
@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wshwsh12, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
* origin/master: (33 commits) build(deps): bump github.com/prometheus/common from 0.55.0 to 0.57.0 (pingcap#55762) build(deps): bump golang.org/x/sys from 0.24.0 to 0.25.0 (pingcap#55894) planner: fix incorrect estRows with global index and json column (pingcap#55842) ddl, stat: switch to new struct for add/truncate/drop partition (pingcap#55893) planner: hide instance plan cache eviction log if no plan is evicted (pingcap#55918) expression: support tidb encode key function (pingcap#51678) planner: fix incorrect maintenance of `handleColHelper` for recursive CTE (pingcap#55732) executor: some code refine of hash join v2 (pingcap#55887) infoschema, meta: fix wrong auto id after `rename table` (pingcap#55847) ddl/ingest: set `minCommitTS` when detect remote duplicate keys (pingcap#55588) planner: move index advisor into the kernel (pingcap#55874) ddl, stats: switch to new struct for create/truncate table (pingcap#55811) executor: avoid new small objects in probe stage of hash join v2 (pingcap#55855) *: Add tidbCPU/tikvCPU into system tables (pingcap#55455) ddl: use static contexts in `NewReorgCopContext` (pingcap#55823) executor: fix index out of range bug in hash join v2 (pingcap#55864) executor: record index usage for the clustered primary keys (pingcap#55602) domain: load all non-public tables into infoschema (pingcap#55142) test: fix unstable TestShowViewPriv (pingcap#55868) ttl: add `varbinary` case for `TestSplitTTLScanRangesWithBytes` (pingcap#55863) ...
What problem does this PR solve?
Issue Number: ref #53127
Problem Summary:
What changed and how does it work?
NO logical changes, only some code reorg
TableMetato a seperate fileTableMetatojoinTableMetarowTableBuilderto a seperate fileCheck List
Tests
Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.