executor: fix data race in IndexNestedLoopHashJoin

[solotzg]

What problem does this PR solve?

Issue Number: close #49692

Problem Summary:

• IndexNestedLoopHashJoin.panicErr is not thread-safe

What changed and how does it work?

• make IndexNestedLoopHashJoin.panicErr can not be read until it has been initialized.
• add failpoint TestIssue49692 to make sure the context done branch can be executed.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Manual test:

• Remove

  tidb/pkg/executor/join/index_lookup_hash_join.go

  Lines 204 to 209 in 4a1a771

  	if !e.KeepOuterOrder {
  	e.resultCh <- &indexHashJoinResult{err: err}
  	} else {
  	task := &indexHashJoinTask{err: err}
  	e.taskCh <- task
  	}

  and make sure

  tidb/pkg/executor/join/index_lookup_hash_join.go

  Lines 302 to 306 in 4a1a771

  	failpoint.Inject("TestIssue49692", func() {
  	for !e.panicErr.Load() {
  	runtime.Gosched()
  	}
  	})

  can be triggered.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @solotzg. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 56.4173%. Comparing base (eb19c10) to head (f36bc7a).
Report is 27 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #55824         +/-   ##
=================================================
- Coverage   72.8613%   56.4173%   -16.4441%     
=================================================
  Files          1595       1728        +133     
  Lines        449065     624992     +175927     
=================================================
+ Hits         327195     352604      +25409     
- Misses       101574     248574     +147000     
- Partials      20296      23814       +3518     

Flag	Coverage Δ
integration	37.5592% <5.2631%> (?)
unit	71.9436% <63.1578%> (+0.0059%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9567% <ø> (+0.0266%)	⬆️
parser	∅ <ø> (∅)
br	52.6590% <ø> (+7.2834%)	⬆️

[solotzg]

/test unit-test

[tiprow]

@solotzg: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[solotzg]

/cc @XuHuaiyu @wshwsh12

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wshwsh12, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [XuHuaiyu,wshwsh12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-09-04 08:04:34.130023504 +0000 UTC m=+431598.648076443: ☑️ agreed by XuHuaiyu.
• 2024-09-04 08:24:27.795540411 +0000 UTC m=+432792.313593334: ☑️ agreed by wshwsh12.

[ti-chi-bot]

@solotzg: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
idc-jenkins-ci-tidb/unit-test	f36bc7a	link	unknown	/test unit-test
pull-integration-ddl-test	f36bc7a	link	unknown	/test pull-integration-ddl-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[solotzg]

/retest-required

[tiprow]

@solotzg: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.1: #55907.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #55908.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.5: #55909.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #55910.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.1: #55911.