-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix data race in IndexNestedLoopHashJoin
(#55824)
#55910
executor: fix data race in IndexNestedLoopHashJoin
(#55824)
#55910
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #55910 +/- ##
================================================
Coverage ? 73.5922%
================================================
Files ? 1211
Lines ? 381381
Branches ? 0
================================================
Hits ? 280667
Misses ? 82905
Partials ? 17809 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wshwsh12, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #55824
What problem does this PR solve?
Issue Number: close #49692
Problem Summary:
IndexNestedLoopHashJoin.panicErr
is not thread-safeWhat changed and how does it work?
IndexNestedLoopHashJoin.panicErr
can not be read until it has been initialized.TestIssue49692
to make sure the context done branch can be executed.Check List
Tests
Manual test:
tidb/pkg/executor/join/index_lookup_hash_join.go
Lines 204 to 209 in 4a1a771
tidb/pkg/executor/join/index_lookup_hash_join.go
Lines 302 to 306 in 4a1a771
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.