Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttl: always enable all read engines for TTL sessions #56604

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

YangKeao
Copy link
Member

What problem does this PR solve?

Issue Number: close #56402

Problem Summary:

If a TiDB node doesn't enable TiKV read engine, running TTL task may fail if the table doesn't have tiflash replica.

What changed and how does it work?

This PR always enables all read engines for TTL sessions.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the issue that if the `isolation-read.engines` config is set without `tikv`, the TTL task may fail.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/invalid-title size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 12, 2024
@YangKeao YangKeao requested a review from lcwangchao October 12, 2024 06:02
@YangKeao YangKeao changed the title always enable all read engines for TTL sessions ttl: always enable all read engines for TTL sessions Oct 12, 2024
@YangKeao YangKeao requested a review from bb7133 October 12, 2024 06:03
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 12 lines in your changes missing coverage. Please review.

Project coverage is 57.8568%. Comparing base (f0b3bf0) to head (ee47ef7).
Report is 70 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56604         +/-   ##
=================================================
- Coverage   73.3452%   57.8568%   -15.4884%     
=================================================
  Files          1628       1759        +131     
  Lines        449555     645830     +196275     
=================================================
+ Hits         329727     373657      +43930     
- Misses        99598     248372     +148774     
- Partials      20230      23801       +3571     
Flag Coverage Δ
integration 38.2879% <17.8571%> (?)
unit 74.1597% <57.1428%> (+1.7061%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 53.1370% <ø> (+7.5292%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 12, 2024
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@YangKeao
Copy link
Member Author

/retest

@YangKeao YangKeao requested a review from hawkingrei October 14, 2024 07:27
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 22, 2024
Copy link

ti-chi-bot bot commented Oct 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-12 06:32:13.602615265 +0000 UTC m=+79930.751525081: ☑️ agreed by lcwangchao.
  • 2024-10-22 02:50:04.825984322 +0000 UTC m=+319405.522774929: ☑️ agreed by bb7133.

@YangKeao
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 670e970 into pingcap:master Oct 22, 2024
23 checks passed
@YangKeao YangKeao added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Oct 23, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 23, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #56805.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 23, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #56806.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #56807.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 23, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
4 participants