-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ttl: always enable all read engines for TTL sessions (#56604) #56805
ttl: always enable all read engines for TTL sessions (#56604) #56805
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #56805 +/- ##
================================================
Coverage ? 73.1330%
================================================
Files ? 1415
Lines ? 420022
Branches ? 0
================================================
Hits ? 307175
Misses ? 93081
Partials ? 19766
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #56604
What problem does this PR solve?
Issue Number: close #56402
Problem Summary:
If a TiDB node doesn't enable
TiKV
read engine, running TTL task may fail if the table doesn't have tiflash replica.What changed and how does it work?
This PR always enables all read engines for TTL sessions.
Check List
Tests
Side effects
Documentation
Release note