Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick 52834 to release 8.1 #57204

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Nov 7, 2024

What problem does this PR solve?

Issue Number: close #52791, close #52792

Problem Summary:
When dropping a subscription manager, the pending events will be dropped. So the test case will fail.

What changed and how does it work?

Wait until it seems there isn't new events.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
> go test --count=100 -run '^TestSomeOfStoreUnsupported|TestStoreRemoved$' github.com/pingcap/tidb/br/pkg/streamhelper
ok      github.com/pingcap/tidb/br/pkg/streamhelper     40.463s
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/planner SIG: Planner labels Nov 7, 2024
Copy link

tiprow bot commented Nov 7, 2024

Hi @YuJuncen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

close pingcap#52791, close pingcap#52792

Signed-off-by: hillium <yujuncen@pingcap.com>
@YuJuncen YuJuncen force-pushed the cherry-pick-52834-to-release-8.1 branch from 7406f8a to 618f61e Compare November 7, 2024 09:11
@ti-chi-bot ti-chi-bot bot added the component/dumpling This is related to Dumpling of TiDB. label Nov 7, 2024
Copy link

ti-chi-bot bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from yujuncen and additionally assign bb7133, benjamin2037, benmeadowcroft, d3hunter, winoros, zanmato1984 for approval(Please ensuring that each of them provides their approval before proceeding). For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@YuJuncen YuJuncen changed the base branch from master to release-7.1 November 7, 2024 09:12
@YuJuncen YuJuncen requested a review from a team as a code owner November 7, 2024 09:12
Copy link

ti-chi-bot bot commented Nov 7, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@YuJuncen YuJuncen changed the base branch from release-7.1 to release-8.1 November 7, 2024 09:12
Copy link

ti-chi-bot bot commented Nov 7, 2024

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/invalid-title label, please follow title format, for example pkg [, pkg2, pkg3]: what is changed or *: what is changed.

📖 For more info, you can check the "Contribute Code" section in the development guide.

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 7, 2024
@YuJuncen
Copy link
Contributor Author

YuJuncen commented Nov 7, 2024

(It is empty now...)

@YuJuncen YuJuncen closed this Nov 7, 2024
Copy link

ti-chi-bot bot commented Nov 7, 2024

@YuJuncen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-ddl-test 618f61e link true /test pull-integration-ddl-test
pull-lightning-integration-test 618f61e link true /test pull-lightning-integration-test
pull-mysql-client-test 618f61e link true /test pull-mysql-client-test
pull-br-integration-test 618f61e link true /test pull-br-integration-test
pull-unit-test-ddlv1 618f61e link true /test pull-unit-test-ddlv1
idc-jenkins-ci-tidb/build 618f61e link true /test build
idc-jenkins-ci-tidb/check_dev 618f61e link true /test check-dev
idc-jenkins-ci-tidb/check_dev_2 618f61e link true /test check-dev2
idc-jenkins-ci-tidb/unit-test 618f61e link true /test unit-test
idc-jenkins-ci-tidb/mysql-test 618f61e link true /test mysql-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dumpling This is related to Dumpling of TiDB. do-not-merge/cherry-pick-not-approved do-not-merge/invalid-title needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test TestSomeOfStoreUnsupported flaky test TestStoreRemoved
1 participant