Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix random cte error under apply (#57294) #57409

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57294

What problem does this PR solve?

Issue Number: close #55881

Problem Summary:
The root cause is described in #55881 (comment)

This pr fix it by

  1. when close the cte producer, check if e.producer.resTbl.Done() is false, which means the producer is opened without produce, in this case, close will reset the cte producer
  2. before produce the cte producer, double check if it is already opened, if not, then open the cte producer before actually produce it.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Nov 15, 2024
@windtalker
Copy link
Contributor

/test unit-test

Copy link

tiprow bot commented Nov 15, 2024

@windtalker: No presubmit jobs available for pingcap/tidb@release-8.1

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 15, 2024
Copy link

ti-chi-bot bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [guo-shaoge,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 15, 2024
Copy link

ti-chi-bot bot commented Nov 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-15 06:34:36.969082837 +0000 UTC m=+597239.159951833: ☑️ agreed by windtalker.
  • 2024-11-15 06:47:22.195798167 +0000 UTC m=+598004.386667165: ☑️ agreed by guo-shaoge.

@windtalker
Copy link
Contributor

/test check-dev2

Copy link

tiprow bot commented Nov 15, 2024

@windtalker: No presubmit jobs available for pingcap/tidb@release-8.1

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 73.52941% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@1a581e1). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #57409   +/-   ##
================================================
  Coverage               ?   71.3656%           
================================================
  Files                  ?       1467           
  Lines                  ?     424144           
  Branches               ?          0           
================================================
  Hits                   ?     302693           
  Misses                 ?     100969           
  Partials               ?      20482           
Flag Coverage Δ
unit 71.3656% <73.5294%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.3424% <0.0000%> (?)

@windtalker
Copy link
Contributor

/test unit-test

Copy link

tiprow bot commented Nov 15, 2024

@windtalker: No presubmit jobs available for pingcap/tidb@release-8.1

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@windtalker
Copy link
Contributor

/test build

Copy link

tiprow bot commented Nov 18, 2024

@windtalker: No presubmit jobs available for pingcap/tidb@release-8.1

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@windtalker
Copy link
Contributor

/test check-dev2

Copy link

tiprow bot commented Nov 18, 2024

@windtalker: No presubmit jobs available for pingcap/tidb@release-8.1

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit bacf8f0 into pingcap:release-8.1 Nov 18, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants