-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix random cte error under apply (#57294) #57409
executor: fix random cte error under apply (#57294) #57409
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
/test unit-test |
@windtalker: No presubmit jobs available for pingcap/tidb@release-8.1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guo-shaoge, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/test check-dev2 |
@windtalker: No presubmit jobs available for pingcap/tidb@release-8.1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #57409 +/- ##
================================================
Coverage ? 71.3656%
================================================
Files ? 1467
Lines ? 424144
Branches ? 0
================================================
Hits ? 302693
Misses ? 100969
Partials ? 20482
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test unit-test |
@windtalker: No presubmit jobs available for pingcap/tidb@release-8.1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test build |
@windtalker: No presubmit jobs available for pingcap/tidb@release-8.1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test check-dev2 |
@windtalker: No presubmit jobs available for pingcap/tidb@release-8.1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #57294
What problem does this PR solve?
Issue Number: close #55881
Problem Summary:
The root cause is described in #55881 (comment)
This pr fix it by
e.producer.resTbl.Done()
is false, which means the producer is opened without produce, in this case, close will reset the cte producerWhat changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.