variable: remove tidb_ddl_reorg_worker_cnt and tidb_ddl_reorg_batch_size session level. #8941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ize session level.
|
/run-all-tests |
crazycs520
force-pushed
the
ddl-reorg-variable
branch
from
02f820b
to
35dc13e
Compare
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #8941 +/- ##
==========================================
- Coverage 67.59% 67.56% -0.04%
==========================================
Files 363 363
Lines 75317 75329 +12
==========================================
- Hits 50913 50896 -17
- Misses 19918 19940 +22
- Partials 4486 4493 +7
Continue to review full report at Codecov.
|
|
Please remember to update the doc |
zimulala
reviewed
Jan 7, 2019
crazycs520
force-pushed
the
ddl-reorg-variable
branch
from
d6ce454
to
ece7943
Compare
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
jackysp
reviewed
Jan 9, 2019
jackysp
reviewed
Jan 9, 2019
|
/run-all-tests |
|
/run-all-tests |
jackysp
approved these changes
Jan 10, 2019
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Jan 21, 2019
…ize session level. (pingcap#8941)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
tidb_ddl_reorg_worker_cnt, tidb_ddl_reorg_batch_size is only take effect in DDL owner server. It meaningless for the session variable. So I remove the session level and only keep the global level.
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Should update doc.
This change is