Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

variable: remove tidb_ddl_reorg_worker_cnt and tidb_ddl_reorg_batch_size session level. #9134

Merged
merged 4 commits into from
Jan 28, 2019
Merged

variable: remove tidb_ddl_reorg_worker_cnt and tidb_ddl_reorg_batch_size session level. #9134

merged 4 commits into from
Jan 28, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

cherry-pick #8941

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • Possible performance regression

Related changes

  • Need to cherry-pick to the release branch

@crazycs520
Copy link
Contributor Author

/run-all-tests pd=release-2.1 tikv=release-2.1 tidb-test=release-2.1

@crazycs520
Copy link
Contributor Author

@winkyao @zimulala @ciscoxll PTAL

jackysp
jackysp reviewed Jan 21, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zimulala
zimulala reviewed Jan 21, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 21, 2019
@zz-jason zz-jason merged commit 0280bcd into pingcap:release-2.1 Jan 28, 2019
@crazycs520 crazycs520 deleted the 8941-2.1 branch January 28, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crazycs520 @zimulala @jackysp @zz-jason