Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call For Participation: implement function push down #5092

Open
Willendless opened this issue Jun 9, 2022 · 6 comments
Open

Call For Participation: implement function push down #5092

Willendless opened this issue Jun 9, 2022 · 6 comments
Labels
component/compute good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement. type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@Willendless
Copy link
Contributor

Willendless commented Jun 9, 2022

We need to push down more functions to maximize TiFlash computation power!

Contributions are welcomed! BTW, it's better to file a PR for every single function.

For more details, please refer to our dev guideline

operator functions

func issue assignee pr progress
LeftShift #5099 @AnnieoftheStars #5495 ✔︎
RightShift #5100 @Willendless #5156 ✔︎
BitCount #5101 @hanzizhao1998 #5101
NullEq #5102 @JigaoLuo #6057

string functions

func issue assignee pr progress
Bin #5103 @An-DJ #5246 ✔︎
Elt #5104 @Willendless #5496 ✔︎
BitLength #5105 @isHuangXin #6078
Char #5106 @Ziy1-Tan
HexIntArg/HexStrArg #5107 @YangKeao #5280 ✔︎
InsertUTF8/Insert #5108 @lizhenhuan
InstrUTF8/Instr #5109 @lizhenhuan #6081
OctInt/OctString #5110 @Ziy1-Tan #6064
ReverseUTF8/Reverse #5111 @lizhenhuan #5233 ✔︎
UnHex #5112 @b41sh #5686 ✔︎
Space #5113 @lizhenhuan #5239 ✔︎
Repeat #5114 @likzn #5276 ✔︎

Cast functions

func issue assignee pr progress
CastTimeAsDuration #5306 @AntiTopQuark #5548 ✔︎

Date/Time functions

func issue assignee pr progress
GetFormat #5115 @wirybeaver #5269 ✔︎
TimeToSec #5116 @hey-kong #5235 ✔︎

aggregation functions

func issue assignee pr progress
Agg_BitOr #5118 @RinChanNOWWW #5293

other functions

func issue assignee pr progress
IsIPv4 #5120 @AntiTopQuark #6773 ✔︎
IsIPv6 #5121 @AntiTopQuark #6773 ✔︎

23:36:23 UTC+8 Monday, August 15, 2022

@Willendless Willendless added the type/enhancement The issue or PR belongs to an enhancement. label Jun 9, 2022
@ywqzzy ywqzzy added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jun 9, 2022
@SeaRise SeaRise added component/compute help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/feature-request Categorizes issue or PR as related to a new feature. labels Jun 9, 2022
@Lloyd-Pottiger
Copy link
Contributor

Maybe you could give an example which will help new hands a lot?

@Willendless
Copy link
Contributor Author

Willendless commented Jun 11, 2022

Maybe you could give an example which will help new hands a lot?

Sure, after we publish an official development guideline, we will add a link here.

@JaySon-Huang
Copy link
Contributor

Maybe mark those issues with the label "help wanted" and remove the "Call for Participation:" from those titles?

@JigaoLuo
Copy link
Contributor

Is the issue be assigned in a first-come-first-serve style?

@ywqzzy
Copy link
Contributor

ywqzzy commented Sep 19, 2022

@Cerdore @mathspanda @johnhaxx7 @fkuner @xiaoshengMr @wzymumon @selectbook @Yxa2111 @raspberry-hu @JialuGong
Hi guys, Thank you for your participation. Do you still have any time to contribute to the issues? Since they are not updated for some time, we want to check if you are still working on them. If you are still working on the issue, please reply "Yes" in 2 days, or I will unassign the tasks. If the tasks are accidentally unassigned, you can assign the tasks again if you are working on it.
Thanks again for your attention!

@An-DJ
Copy link
Contributor

An-DJ commented Oct 8, 2022

The implementation of Bin in TiDB side had been merged in (pingcap/tidb#37589). @Willendless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/compute good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement. type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

7 participants