Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support function unhex pushdown #5686

Merged
merged 26 commits into from
Dec 29, 2022
Merged

feat: support function unhex pushdown #5686

merged 26 commits into from
Dec 29, 2022

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Aug 23, 2022

What problem does this PR solve?

Issue Number: close #5112

Problem Summary: Implement UnHex function push down

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 23, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 23, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Aug 23, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 23, 2022
@ywqzzy ywqzzy self-requested a review August 24, 2022 03:17
@ywqzzy
Copy link
Contributor

ywqzzy commented Aug 24, 2022

/run-all-tests

@SeaRise SeaRise mentioned this pull request Aug 25, 2022
Open
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2022
@b41sh
Copy link
Member Author

b41sh commented Nov 16, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 19, 2022
@b41sh
Copy link
Member Author

b41sh commented Nov 19, 2022

/run-all-tests

@b41sh
Copy link
Member Author

b41sh commented Nov 19, 2022

/run-all-tests

@b41sh
Copy link
Member Author

b41sh commented Nov 19, 2022

/run-all-tests

@b41sh
Copy link
Member Author

b41sh commented Nov 19, 2022

/run-all-tests

@b41sh
Copy link
Member Author

b41sh commented Nov 21, 2022

@ywqzzy PTAL

ywqzzy
ywqzzy reviewed Nov 21, 2022
View reviewed changes
dbms/src/Functions/tests/gtest_strings_unhex.cpp Show resolved Hide resolved
dbms/src/Functions/tests/gtest_strings_unhex.cpp Outdated Show resolved Hide resolved
dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved
dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved
@mengxin9014
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@mengxin9014: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@mengxin9014: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xzhangxian1008
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 28, 2022
@SeaRise
Copy link
Contributor

SeaRise commented Dec 28, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 28, 2022
@SeaRise
Copy link
Contributor

SeaRise commented Dec 28, 2022

/merge cancel

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Dec 28, 2022
@SeaRise
Copy link
Contributor

SeaRise commented Dec 28, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 28, 2022
@SeaRise
Copy link
Contributor

SeaRise commented Dec 28, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 28, 2022
@SeaRise
Copy link
Contributor

SeaRise commented Dec 28, 2022

/merge cancel

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Dec 28, 2022
@SeaRise
Copy link
Contributor

SeaRise commented Dec 28, 2022

/hold cancel

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 28, 2022
@xzhangxian1008
Copy link
Contributor

/run-all-tests

@SeaRise
Copy link
Contributor

SeaRise commented Dec 29, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 887b308

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 29, 2022
@ti-chi-bot ti-chi-bot merged commit 7a493ef into pingcap:master Dec 29, 2022
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Jan 4, 2023
@b41sh @JaySon-Huang
feat: support function unhex pushdown (pingcap#5686)
e6acef9 
close pingcap#5112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzhangxian1008 xzhangxian1008 xzhangxian1008 left review comments

@ywqzzy ywqzzy ywqzzy approved these changes

@SeaRise SeaRise SeaRise approved these changes

@mengxin9014 mengxin9014 mengxin9014 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement UnHex function push down
7 participants
@b41sh @ti-chi-bot @sre-bot @ywqzzy @xzhangxian1008 @mengxin9014 @SeaRise